Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2526)

Issue 10184043: Fix compile errors in the Azure provider skeleton. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by jtv.canonical
Modified:
10 years, 8 months ago
Reviewers:
gz, mp+168659
Visibility:
Public.

Description

Fix compile errors in the Azure provider skeleton. I broke the build by omitting some imports and such. I forgot that I hadn't built my branch yet, and since lbox usually complains about some build problem or other that's unrelated to my changes, I thought it would run a build either when proposing or submitting. There was talk about enforcing a clean build at that state a while ago. Turns out it never did. https://code.launchpad.net/~jtv/juju-core/azure-compile-fix/+merge/168659 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix compile errors in the Azure provider skeleton. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -0 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
A environs/azure/environ.go View 1 1 chunk +103 lines, -0 lines 0 comments Download
A environs/azure/environprovider.go View 1 1 chunk +50 lines, -0 lines 0 comments Download
A environs/azure/instance.go View 1 1 chunk +45 lines, -0 lines 0 comments Download
A environs/azure/storage.go View 1 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 6
jtv.canonical
Please take a look.
10 years, 10 months ago (2013-06-11 12:47:01 UTC) #1
gz
Not lgtm, branch doesn't include revert/trunk merge in so conflicts trying to land. Please do ...
10 years, 10 months ago (2013-06-11 14:02:08 UTC) #2
jeroen.vermeulen
On 2013/06/11 14:02:08, gz wrote: > Not lgtm, branch doesn't include revert/trunk merge in so ...
10 years, 10 months ago (2013-06-11 14:56:33 UTC) #3
gz
LGTM, merges and builds. On 2013/06/11 14:56:33, jeroen.vermeulen wrote: > On 2013/06/11 14:02:08, gz wrote: ...
10 years, 10 months ago (2013-06-11 16:30:12 UTC) #4
jeroen.vermeulen
On 2013/06/11 16:30:12, gz wrote: > Note, the instructions read `bzr revert *`, that star ...
10 years, 10 months ago (2013-06-11 17:17:17 UTC) #5
jtv.canonical
10 years, 10 months ago (2013-06-11 17:34:15 UTC) #6
*** Submitted:

Fix compile errors in the Azure provider skeleton.

I broke the build by omitting some imports and such.  I forgot that I hadn't
built my branch yet, and since lbox usually complains about some build problem
or other that's unrelated to my changes, I thought it would run a build either
when proposing or submitting.  There was talk about enforcing a clean build at
that state a while ago.  Turns out it never did.

R=gz, jeroen.vermeulen
CC=
https://codereview.appspot.com/10184043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b