Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(568)

Issue 10176043: Better Hash/QS support in router

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by jeff.pihach
Modified:
10 years, 11 months ago
Reviewers:
rharding, mp+168555
Visibility:
Public.

Description

Better Hash/QS support in router This is a small update to bcsaller's original branch to add support for non word characters in the hash key: https://code.launchpad.net/~bcsaller/juju-gui/routing-hash-query/+merge/168351 previous comment: `parse`, `url` and `combine` deal more gracefully with hash and qs url options. In the case of combine the incoming url replaces any existing values in the hash and qs portions of the URL as might be expected. (This is rather than some artificial merge policy for example). https://code.launchpad.net/~hatch/juju-gui/routing-hash-query/+merge/168555 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Better Hash/QS support in router #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -16 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/assets/javascripts/ns-routing-app-extension.js View 1 7 chunks +69 lines, -16 lines 0 comments Download
M test/test_routing.js View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3
jeff.pihach
Please take a look.
10 years, 11 months ago (2013-06-10 22:14:25 UTC) #1
rharding
LGTM with comment about following up on the TODO https://codereview.appspot.com/10176043/diff/1/app/assets/javascripts/ns-routing-app-extension.js File app/assets/javascripts/ns-routing-app-extension.js (right): https://codereview.appspot.com/10176043/diff/1/app/assets/javascripts/ns-routing-app-extension.js#newcode348 app/assets/javascripts/ns-routing-app-extension.js:348: ...
10 years, 11 months ago (2013-06-10 22:25:43 UTC) #2
jeff.pihach
10 years, 11 months ago (2013-06-10 22:44:35 UTC) #3
*** Submitted:

Better Hash/QS support in router

This is a small update to bcsaller's original branch to add support for
non word characters in the hash key:
https://code.launchpad.net/~bcsaller/juju-gui/routing-hash-query/+merge/168351

previous comment:
`parse`, `url` and `combine` deal more gracefully with hash and qs url
options. In the case of combine the incoming url replaces any existing
values in the hash and qs portions of the URL as might be expected. (This
is rather than some artificial merge policy for example).

R=rharding
CC=
https://codereview.appspot.com/10176043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b