Issue 101760045: Do not use BaseSuite in utils if not required.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 101760045: Do not use BaseSuite in utils if not required.

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by frankban

Modified:
9 years, 11 months ago

Reviewers:
mp+220991, fwereade

Visibility:
Public.

Description

Do not use BaseSuite in utils if not required. Another incremental step for decoupling utils stuff from juju-core related code. https://code.launchpad.net/~frankban/juju-core/utils-testing/+merge/220991 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -66 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	utils/apt/apt_test.go	View	2 chunks	+12 lines, -2 lines	1 comment	Download
M	utils/command_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	utils/exec/exec_test.go	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	utils/fslock/fslock_test.go	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	utils/gomaxprocs_test.go	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	utils/isubuntu_test.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	utils/proxy/package_test.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	utils/proxy/proxy_test.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	utils/registry/registry_test.go	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	utils/shell/script_test.go	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	utils/ssh/fingerprint_test.go	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	utils/ssh/generate_test.go	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	utils/ssh/run_test.go	View	6 chunks	+8 lines, -7 lines	0 comments	Download
M	utils/ssh/ssh_gocrypto_test.go	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	utils/ssh/ssh_test.go	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A	utils/tailer/package_test.go	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	utils/tailer/tailer_test.go	View	2 chunks	+4 lines, -8 lines	0 comments	Download
A	utils/voyeur/package_test.go	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	utils/voyeur/value_test.go	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	utils/zip/zip_test.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

fwereade

9 years, 11 months ago (2014-05-27 07:50:22 UTC) #2

I'm rather -1 on this. I see very little that's juju-specific in TestBase -- the
only issue I see is that it clears out only *some* env vars, not *all* of them,
as (I reckon) we ought to do as a matter of course anyway.

Chat live?

https://codereview.appspot.com/101760045/diff/1/utils/apt/apt_test.go
File utils/apt/apt_test.go (right):

https://codereview.appspot.com/101760045/diff/1/utils/apt/apt_test.go#newcode33
utils/apt/apt_test.go:33: s.LoggingSuite.SetUpTest(c)
doesn't CleanupSuite have SetUpTest/TearDownTest? I feel like it should.,..

Expand All Messages | Collapse All Messages