Make Joyent tests run faster

Make Joyent tests run faster

Update dependencies and tweak code to use
upstream fixes to Joyent libs which cache
the parsing of the private signing key.

https://code.launchpad.net/~wallyworld/juju-core/faster-joyent-tests/+merge/220894

(do not edit description out of merge proposal)

[wallyworld, 2014-05-26 00:42:10]

Please take a look.

[axw, 2014-05-26 01:08:04]

A few minor issues, but otherwise LGTM

https://codereview.appspot.com/101740043/diff/1/provider/joyent/config_test.go
File provider/joyent/config_test.go (right):

https://codereview.appspot.com/101740043/diff/1/provider/joyent/config_test.g...
provider/joyent/config_test.go:62: s.PatchValue(&ssh.KeyBits, 32)
PatchValue should be used in a test, not in SetUpSuite. I think PatchValue is
the wrong tool here, though. It should be reset directly after GenerateKey
returns.

I'd split this out to another function which gets the original value and defers
a reset.

https://codereview.appspot.com/101740043/diff/1/provider/joyent/local_test.go
File provider/joyent/local_test.go (right):

https://codereview.appspot.com/101740043/diff/1/provider/joyent/local_test.go...
provider/joyent/local_test.go:105: s.restoreTimeouts =
envtesting.PatchAttemptStrategies(joyent.ShortAttempt)
Why not use s.AddSuiteCleanup?

https://codereview.appspot.com/101740043/diff/1/provider/joyent/provider.go
File provider/joyent/provider.go (right):

https://codereview.appspot.com/101740043/diff/1/provider/joyent/provider.go#n...
provider/joyent/provider.go:25: var shortAttempt = utils.AttemptStrategy{
I think this should go in export_test.go until it's actually needed in the
non-test code.

[dave_cheney.net, 2014-05-26 01:35:08]

Minor comments, passes in 127s on pcc64el

https://codereview.appspot.com/101740043/diff/1/provider/joyent/config_test.go
File provider/joyent/config_test.go (right):

https://codereview.appspot.com/101740043/diff/1/provider/joyent/config_test.g...
provider/joyent/config_test.go:237: continue
barf, i wonder if gocheck.Check could be modified to return a bool or something

https://codereview.appspot.com/101740043/diff/1/provider/joyent/provider.go
File provider/joyent/provider.go (right):

https://codereview.appspot.com/101740043/diff/1/provider/joyent/provider.go#n...
provider/joyent/provider.go:25: var shortAttempt = utils.AttemptStrategy{
On 2014/05/26 01:08:04, axw wrote:
> I think this should go in export_test.go until it's actually needed in the
> non-test code.

seconded

https://codereview.appspot.com/101740043/diff/1/provider/joyent/provider.go#n...
provider/joyent/provider.go:55: return nil, errors.New("cannot create
credentials without a private key")
why is this check needed, is auth.NewAuth likely to accept an empty private key
?

[wallyworld, 2014-05-26 01:48:08]

https://codereview.appspot.com/101740043/diff/1/provider/joyent/config_test.go
File provider/joyent/config_test.go (right):

https://codereview.appspot.com/101740043/diff/1/provider/joyent/config_test.g...
provider/joyent/config_test.go:62: s.PatchValue(&ssh.KeyBits, 32)
On 2014/05/26 01:08:04, axw wrote:
> PatchValue should be used in a test, not in SetUpSuite. I think PatchValue is
> the wrong tool here, though. It should be reset directly after GenerateKey
> returns.
> 
> I'd split this out to another function which gets the original value and
defers
> a reset.

Done.

https://codereview.appspot.com/101740043/diff/1/provider/joyent/local_test.go
File provider/joyent/local_test.go (right):

https://codereview.appspot.com/101740043/diff/1/provider/joyent/local_test.go...
provider/joyent/local_test.go:105: s.restoreTimeouts =
envtesting.PatchAttemptStrategies(joyent.ShortAttempt)
On 2014/05/26 01:08:04, axw wrote:
> Why not use s.AddSuiteCleanup?

Cause I copied existing code. Changed here, had to wrap it in a func(*gc.C){}

https://codereview.appspot.com/101740043/diff/1/provider/joyent/provider.go
File provider/joyent/provider.go (right):

https://codereview.appspot.com/101740043/diff/1/provider/joyent/provider.go#n...
provider/joyent/provider.go:25: var shortAttempt = utils.AttemptStrategy{
On 2014/05/26 01:08:04, axw wrote:
> I think this should go in export_test.go until it's actually needed in the
> non-test code.

Done.

https://codereview.appspot.com/101740043/diff/1/provider/joyent/provider.go#n...
provider/joyent/provider.go:55: return nil, errors.New("cannot create
credentials without a private key")
On 2014/05/26 01:35:08, dfc wrote:
> why is this check needed, is auth.NewAuth likely to accept an empty private
key
> ?

Done.