On 2014/07/07 16:52:20, techtonik wrote:
> Thanks for the patch. LGTM. I can not check if you signed up the CLA at
> https://code.google.com/p/rietveld/wiki/Contributing#Legal_stuff and can not
> commit it for you. Andi can do this or you may ask in codereview-discuss.
Thanks for the change. I verified you didn't sign the CLA yet, can you do it?
Thanks,
M-A
On 2014/07/07 16:59:43, M-A wrote:
> On 2014/07/07 16:52:20, techtonik wrote:
> > Thanks for the patch. LGTM. I can not check if you signed up the CLA at
> > https://code.google.com/p/rietveld/wiki/Contributing#Legal_stuff and can not
> > commit it for you. Andi can do this or you may ask in codereview-discuss.
>
> Thanks for the change. I verified you didn't sign the CLA yet, can you do it?
Done.
On 2014/07/07 17:05:50, ced wrote:
> On 2014/07/07 16:59:43, M-A wrote:
> > On 2014/07/07 16:52:20, techtonik wrote:
> > > Thanks for the patch. LGTM. I can not check if you signed up the CLA at
> > > https://code.google.com/p/rietveld/wiki/Contributing#Legal_stuff and can
not
> > > commit it for you. Andi can do this or you may ask in codereview-discuss.
> >
> > Thanks for the change. I verified you didn't sign the CLA yet, can you do
it?
>
> Done.
Is there something else I must do?
> Is there something else I must do?
I think no, but it may worth to ping Andi, M-A or post a message to
codereview-discuss if nothing happens for a few days.
On 2014/07/19 08:55:21, techtonik wrote: > > Is there something else I must do? > ...
11 years, 12 months ago
(2014-07-26 18:03:44 UTC)
#8
On 2014/07/19 08:55:21, techtonik wrote:
> > Is there something else I must do?
>
> I think no, but it may worth to ping Andi, M-A or post a message to
> codereview-discuss if nothing happens for a few days.
Cedric, sorry for the delays, I've been travelling.
Jason, I confirmed Cedric signed the CLA. Could you commit this patch on his
behalf?
Thanks a lot.
M-A
On 2014/07/26 18:03:44, M-A wrote: > On 2014/07/19 08:55:21, techtonik wrote: > > > Is ...
11 years, 10 months ago
(2014-09-21 14:00:01 UTC)
#9
On 2014/07/26 18:03:44, M-A wrote:
> On 2014/07/19 08:55:21, techtonik wrote:
> > > Is there something else I must do?
> >
> > I think no, but it may worth to ping Andi, M-A or post a message to
> > codereview-discuss if nothing happens for a few days.
>
> Cedric, sorry for the delays, I've been travelling.
>
> Jason, I confirmed Cedric signed the CLA. Could you commit this patch on his
> behalf?
Up.
Issue 101710043: Don't fail if mercurial repository has no parent
(Closed)
Created 12 years ago by ced
Modified 11 years, 10 months ago
Reviewers: techtonik, nicoe, M-A, jrobbins (chromium), jrobbins (corp)
Base URL:
Comments: 0