Issue 10169044: state: Unit.ConfigSettings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10169044: state: Unit.ConfigSettings

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by fwereade

Modified:
10 years, 10 months ago

Reviewers:
mp+168577, thumper, wallyworld, rog

Visibility:
Public.

Description

state: Unit.ConfigSettings Better name, better type; suitable changes propagated amongst clients. https://code.launchpad.net/~fwereade/juju-core/config-3-state-unit-settings-rename/+merge/168577 Requires: https://code.launchpad.net/~fwereade/juju-core/config-2-trivial-error-message-change/+merge/168576 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : state: Unit.ConfigSettings #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -31 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/unit.go	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	state/unit_test.go	View		2 chunks	+13 lines, -13 lines	0 comments	Download
M	worker/uniter/context.go	View		3 chunks	+11 lines, -6 lines	0 comments	Download
M	worker/uniter/context_test.go	View		3 chunks	+5 lines, -4 lines	0 comments	Download
M	worker/uniter/jujuc/config-get.go	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	worker/uniter/jujuc/context.go	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	worker/uniter/jujuc/util_test.go	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

thumper

On 2013/06/11 01:49:24, fwereade wrote: > Please take a look. LGTM - no other comments.

10 years, 10 months ago (2013-06-11 05:17:15 UTC) #2

rog

LGTM https://codereview.appspot.com/10169044/diff/1/worker/uniter/context.go File worker/uniter/context.go (right): https://codereview.appspot.com/10169044/diff/1/worker/uniter/context.go#newcode97 worker/uniter/context.go:97: for name, value := range ctx.configSettings { do ...

10 years, 10 months ago (2013-06-11 12:10:04 UTC) #4

fwereade

10 years, 10 months ago (2013-06-12 00:03:36 UTC) #5

*** Submitted:

state: Unit.ConfigSettings

Better name, better type; suitable changes propagated amongst clients.

R=thumper, wallyworld, rog
CC=
https://codereview.appspot.com/10169044

https://codereview.appspot.com/10169044/diff/1/worker/uniter/context.go
File worker/uniter/context.go (right):

https://codereview.appspot.com/10169044/diff/1/worker/uniter/context.go#newco...
worker/uniter/context.go:97: for name, value := range ctx.configSettings {
On 2013/06/11 12:10:04, rog wrote:
> do we really need to make a copy?

Better safe than sorry. I'm growing more paranoid in my old age.

Expand All Messages | Collapse All Messages