Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(362)

Issue 101690043: Issue 3991: \magnifyMusic - reluctantly surrender to issues 3987 and 3990.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by Mark Polesky
Modified:
9 years, 10 months ago
Reviewers:
pkx166h, pwm, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

http://code.google.com/p/lilypond/issues/detail?id=3991 Until issues 3987 and 3990 are fixed, \magnifyMusic is broken, so I'm turning off some of the intended functionality, and putting a note in the docs. Related issues: inconsistent spacing with spacing-increment http://code.google.com/p/lilypond/issues/detail?id=3987 \newSpacingSection + change fontSize = mess http://code.google.com/p/lilypond/issues/detail?id=3990

Patch Set 1 : Initial Patch set #

Patch Set 2 : Reluctantly surrender to issues 3987 and 3990. #

Total comments: 1

Patch Set 3 : Fix compile. #

Total comments: 2

Patch Set 4 : Fix typo. #

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M Documentation/changes.tely View 1 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/notation/editorial.itely View 1 2 3 4 chunks +27 lines, -0 lines 0 comments Download
M ly/music-functions-init.ly View 1 2 3 4 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5
pkx166h
https://codereview.appspot.com/101690043/diff/20001/Documentation/notation/editorial.itely File Documentation/notation/editorial.itely (right): https://codereview.appspot.com/101690043/diff/20001/Documentation/notation/editorial.itely#newcode310 Documentation/notation/editorial.itely:310: \magnifyMusic @var{mag} { I think this is breaking make, ...
9 years, 10 months ago (2014-07-05 04:33:57 UTC) #1
pwm
Happened to see another little simplification. https://codereview.appspot.com/101690043/diff/40001/scm/music-functions.scm File scm/music-functions.scm (right): https://codereview.appspot.com/101690043/diff/40001/scm/music-functions.scm#newcode2452 scm/music-functions.scm:2452: (lambda (x) x))) ...
9 years, 10 months ago (2014-07-05 14:17:23 UTC) #2
Mark Polesky
On 2014/07/05 14:17:23, pwm wrote: > Happened to see another little simplification. > ... > ...
9 years, 10 months ago (2014-07-05 16:58:38 UTC) #3
dak
https://codereview.appspot.com/101690043/diff/40001/scm/music-functions.scm File scm/music-functions.scm (right): https://codereview.appspot.com/101690043/diff/40001/scm/music-functions.scm#newcode2452 scm/music-functions.scm:2452: (lambda (x) x))) On 2014/07/05 14:17:23, pwm wrote: > ...
9 years, 10 months ago (2014-07-06 13:04:12 UTC) #4
dak
9 years, 10 months ago (2014-07-06 13:06:07 UTC) #5
On 2014/07/05 16:58:38, Mark Polesky wrote:
> On 2014/07/05 14:17:23, pwm wrote:
> > Happened to see another little simplification.
> > ...
> > Can be simplified: (lambda (x) x) is the same as x
> 
> Not in this case; guile would complain about unbound variable x.  I could have
> used the guile function `identity', but I opted not to since it's not
documented
> in the guile manual.

It is not documented in the GUILEv1 manual, but it *is* documented in the
GUILEv2 manual, so it is not going to go away.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b