Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 101670045: code review 101670045: go.image/draw: new package, a superset of the standard ...

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by nigeltao
Modified:
4 years, 5 months ago
Reviewers:
CC:
r, chai2010, klauspost, bradfitz, wathiede, golang-codereviews
Visibility:
Public.

Description

go.image/draw: new package, a superset of the standard library's image/draw package, including the ability to scale an image.

Patch Set 1 #

Patch Set 2 : diff -r e492ffa4cad4 https://code.google.com/p/go.image #

Patch Set 3 : diff -r e492ffa4cad4 https://code.google.com/p/go.image #

Patch Set 4 : diff -r e492ffa4cad4 https://code.google.com/p/go.image #

Total comments: 13

Patch Set 5 : diff -r e492ffa4cad4 https://code.google.com/p/go.image #

Patch Set 6 : diff -r e492ffa4cad4 https://code.google.com/p/go.image #

Patch Set 7 : diff -r e492ffa4cad4 https://code.google.com/p/go.image #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+537 lines, -0 lines) Patch
A draw/draw.go View 1 2 3 4 1 chunk +79 lines, -0 lines 0 comments Download
A draw/scale.go View 1 2 3 4 5 6 1 chunk +351 lines, -0 lines 1 comment Download
A draw/scale_test.go View 1 2 3 4 1 chunk +107 lines, -0 lines 2 comments Download
A testdata/go-turns-two-14x18.png View 1 Binary file 0 comments Download
A testdata/go-turns-two-280x360.jpeg View 1 Binary file 0 comments Download
A testdata/go-turns-two-down-default.png View 1 Binary file 0 comments Download
A testdata/go-turns-two-down-fastest.png View 1 Binary file 0 comments Download
A testdata/go-turns-two-down-nicest.png View 1 Binary file 0 comments Download
A testdata/go-turns-two-up-default.png View 1 Binary file 0 comments Download
A testdata/go-turns-two-up-fastest.png View 1 Binary file 0 comments Download
A testdata/go-turns-two-up-nicest.png View 1 Binary file 0 comments Download

Messages

Total messages: 8
nigeltao
Hello r@golang.org (cc: bradfitz@golang.org, couchmoney@gmail.com, golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.image
5 years ago (2014-07-04 08:52:02 UTC) #1
chai2010
https://codereview.appspot.com/101670045/diff/40001/draw/scale.go File draw/scale.go (right): https://codereview.appspot.com/101670045/diff/40001/draw/scale.go#newcode1 draw/scale.go:1: package draw copyright missing https://codereview.appspot.com/101670045/diff/40001/draw/scale_test.go File draw/scale_test.go (right): https://codereview.appspot.com/101670045/diff/40001/draw/scale_test.go#newcode69 ...
5 years ago (2014-07-04 10:50:33 UTC) #2
klauspost
Hi! I have implemented a few scalers, so the algorithms are fairly familiar to me. ...
5 years ago (2014-07-06 21:05:11 UTC) #3
nigeltao
https://codereview.appspot.com/101670045/diff/40001/draw/scale.go File draw/scale.go (right): https://codereview.appspot.com/101670045/diff/40001/draw/scale.go#newcode1 draw/scale.go:1: package draw On 2014/07/04 10:50:32, chai2010 wrote: > copyright ...
5 years ago (2014-07-07 00:58:40 UTC) #4
r
https://codereview.appspot.com/101670045/diff/100001/draw/scale.go File draw/scale.go (right): https://codereview.appspot.com/101670045/diff/100001/draw/scale.go#newcode20 draw/scale.go:20: NicestQuality Quality = +1 not sure i like these ...
5 years ago (2014-07-08 19:44:54 UTC) #5
klauspost
Sorry, didn't realize I hadn't published this. TL;DR, the suggested bilinear is broken, and will ...
4 years, 12 months ago (2014-07-17 09:55:18 UTC) #6
gobot
R=close To the author of this CL: The Go project has moved to Gerrit Code ...
4 years, 6 months ago (2014-12-19 05:06:11 UTC) #7
nigeltao
4 years, 5 months ago (2015-02-09 05:11:55 UTC) #8
Sorry, I got interrupted by other work and dropped this CL.

Please continue the conversation on http://golang.org/cl/4210
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b