Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2256)

Issue 101670043: code review 101670043: go.crypt/ssh/terminal: declare TCGETS, TCSETS constants... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by dfc
Modified:
6 years, 6 months ago
Reviewers:
hanwen-google, iant
CC:
hanwen-google, iant, gobot, golang-codereviews
Visibility:
Public.

Description

go.crypt/ssh/terminal: declare TCGETS, TCSETS constants locally. Currently the ssh/terminal package cannot be compiled under gccgo. Even though gccgo may be running on linux, its syscall package is slightly different and does not contain these constants. This proposal resolves the issue by declaring the two constants locally, as we've done for the *BSDs.

Patch Set 1 #

Patch Set 2 : diff -r 1064b89a6fb5 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 1064b89a6fb5 https://code.google.com/p/go.crypto #

Total comments: 1

Patch Set 4 : diff -r 5478be1963aa https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r 1064b89a6fb5 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M ssh/terminal/util_linux.go View 1 2 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 7
dfc
Hello hanwen@google.com, iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
6 years, 8 months ago (2014-07-03 08:02:38 UTC) #1
hanwen-google
LGTM https://codereview.appspot.com/101670043/diff/10002/ssh/terminal/util_linux.go File ssh/terminal/util_linux.go (left): https://codereview.appspot.com/101670043/diff/10002/ssh/terminal/util_linux.go#oldcode5 ssh/terminal/util_linux.go:5: // +build linux for entirely selfish reasons, I'd ...
6 years, 8 months ago (2014-07-03 09:54:41 UTC) #2
gobot
R=iant@golang.org (assigned by dave@cheney.net)
6 years, 8 months ago (2014-07-03 10:02:58 UTC) #3
iant
LGTM Current gccgo does declare these constants, but they are unlikely to change.
6 years, 8 months ago (2014-07-05 20:47:29 UTC) #4
dfc
On 6 Jul 2014 06:47, <iant@golang.org> wrote: > > LGTM > > Current gccgo does ...
6 years, 7 months ago (2014-07-06 04:42:05 UTC) #5
iant
On Sat, Jul 5, 2014 at 9:42 PM, Dave Cheney <dave@cheney.net> wrote: > > On ...
6 years, 7 months ago (2014-07-06 20:25:07 UTC) #6
dfc
6 years, 7 months ago (2014-07-07 00:24:52 UTC) #7
*** Submitted as
https://code.google.com/p/go/source/detail?r=aa2644fe4aa5&repo=crypto ***

go.crypt/ssh/terminal: declare TCGETS, TCSETS constants locally.

Currently the ssh/terminal package cannot be compiled under gccgo. Even though
gccgo may be running on linux, its syscall package is slightly different and
does not contain these constants.

This proposal resolves the issue by declaring the two constants locally, as
we've done for the *BSDs.

LGTM=hanwen, iant
R=hanwen, iant, gobot
CC=golang-codereviews
https://codereview.appspot.com/101670043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b