Issue 101620043: code review 101620043: syscall: nacl/arm support.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 101620043: code review 101620043: syscall: nacl/arm support. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by minux

Modified:
10 years, 11 months ago

Reviewers:
gobot, rsc, dave

CC:
rsc, iant, dave_cheney.net, golang-codereviews

Visibility:
Public.

Patch Set 2 : diff -r fbd798b1842c https://code.google.com/p/go #

Patch Set 3 : diff -r fbd798b1842c https://code.google.com/p/go #

Patch Set 4 : diff -r fca86a5afe65 https://code.google.com/p/go #

Patch Set 5 : diff -r 90b145a49a65 https://code.google.com/p/go #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -5 lines)			Patch
A	src/pkg/syscall/asm_nacl_arm.s	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_nacl_arm.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/time_nacl_arm.s	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_nacl_arm.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

minux

Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 11 months ago (2014-07-02 00:31:57 UTC) #1

rsc

LGTM fwiw when you 'hg cp' you don't need to change the copyright year. don't ...

10 years, 11 months ago (2014-07-09 16:17:38 UTC) #3

minux

*** Submitted as https://code.google.com/p/go/source/detail?r=4ddb20def0bc *** syscall: nacl/arm support. LGTM=dave, rsc R=rsc, iant, dave CC=golang-codereviews https://codereview.appspot.com/101620043

10 years, 11 months ago (2014-07-10 19:15:10 UTC) #4

gobot

This CL appears to have broken the plan9-386-cnielsen builder. See http://build.golang.org/log/94ae2f86d39e3d20b52aee09d5db4df65e02b1b4

10 years, 11 months ago (2014-07-11 01:10:50 UTC) #5

minux

10 years, 11 months ago (2014-07-11 01:35:47 UTC) #6

On Thu, Jul 10, 2014 at 9:10 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the plan9-386-cnielsen builder.
> See http://build.golang.org/log/94ae2f86d39e3d20b52aee09d5db4df65e02b1b
> <http://build.golang.org/log/94ae2f86d39e3d20b52aee09d5db4df65e02b1b4>

/test test timed out. unrelated.

Expand All Messages | Collapse All Messages