Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(252)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 10158043: api issue 796: Remove Beta API deprecated in 1.15 [backwards incompatible] (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by yanivi
Modified:
13 years, 4 months ago
Reviewers:
ngmiceli
CC:
peleyal
Base URL:
https://code.google.com/p/google-api-java-client/
Visibility:
Public.

Description

api issue 796: Remove Beta API deprecated in 1.15 [backwards incompatible] https://code.google.com/p/google-api-java-client/issues/detail?id=796

Patch Set 1 #

Total comments: 10

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -818 lines) Patch
M clirr-ignored-differences.xml View 1 1 chunk +100 lines, -1 line 0 comments Download
M google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java View 1 chunk +0 lines, -22 lines 0 comments Download
M google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/AppIdentityCredential.java View 5 chunks +0 lines, -70 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleAuthorizationCodeFlow.java View 1 4 chunks +0 lines, -84 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleAuthorizationCodeRequestUrl.java View 6 chunks +0 lines, -97 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleAuthorizationCodeTokenRequest.java View 4 chunks +6 lines, -34 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleBrowserClientRequestUrl.java View 5 chunks +0 lines, -74 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleClientSecrets.java View 2 chunks +0 lines, -15 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java View 1 5 chunks +0 lines, -58 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleRefreshTokenRequest.java View 2 chunks +0 lines, -15 lines 0 comments Download
R google-api-client/src/main/java/com/google/api/client/googleapis/json/GoogleJsonRpcHttpTransport.java View 1 chunk +0 lines, -331 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/media/MediaHttpDownloader.java View 2 chunks +2 lines, -2 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/media/MediaHttpUploader.java View 2 chunks +2 lines, -2 lines 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/auth/oauth2/GoogleClientSecretsTest.java View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 5
yanivi
13 years, 4 months ago (2013-06-10 18:22:20 UTC) #1
ngmiceli
https://codereview.appspot.com/10158043/diff/1/google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java File google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java (left): https://codereview.appspot.com/10158043/diff/1/google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java#oldcode118 google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java:118: public static GoogleAccountCredential usingOAuth2( This removal is missing from ...
13 years, 4 months ago (2013-06-19 15:07:53 UTC) #2
yanivi
https://codereview.appspot.com/10158043/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/media/MediaHttpDownloader.java File google-api-client/src/main/java/com/google/api/client/googleapis/media/MediaHttpDownloader.java (right): https://codereview.appspot.com/10158043/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/media/MediaHttpDownloader.java#newcode51 google-api-client/src/main/java/com/google/api/client/googleapis/media/MediaHttpDownloader.java:51: * Upgrade warning: in prior version 1.14 exponential back-off ...
13 years, 4 months ago (2013-06-19 16:41:13 UTC) #3
ngmiceli
LGTM
13 years, 4 months ago (2013-06-19 16:54:29 UTC) #4
yanivi
13 years, 4 months ago (2013-06-19 17:39:16 UTC) #5 
https://codereview.appspot.com/10158043/diff/1/google-api-client-android/src/...
File
google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java
(left):

https://codereview.appspot.com/10158043/diff/1/google-api-client-android/src/...
google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java:118:
public static GoogleAccountCredential usingOAuth2(
On 2013/06/19 15:07:53, ngmiceli wrote:
> This removal is missing from clirr-ignored-differences. Please add.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b