Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4892)

Issue 101570044: code review 101570044: undo CL 104200047 / 318b04f28372 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by khr
Modified:
9 years, 10 months ago
Reviewers:
gobot
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

undo CL 104200047 / 318b04f28372 Breaks windows and race detector. TBR=rsc ««« original CL description runtime: stack allocator, separate from mallocgc In order to move malloc to Go, we need to have a separate stack allocator. If we run out of stack during malloc, malloc will not be available to allocate a new stack. Stacks are the last remaining FlagNoGC objects in the GC heap. Once they are out, we can get rid of the distinction between the allocated/blockboundary bits. (This will be in a separate change.) Fixes issue 7468 Fixes issue 7424 LGTM=rsc, dvyukov R=golang-codereviews, dvyukov, khr, dave, rsc CC=golang-codereviews https://codereview.appspot.com/104200047 »»»

Patch Set 1 #

Patch Set 2 : diff -r 318b04f28372 https://khr%40golang.org@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -491 lines) Patch
M src/pkg/runtime/malloc.h View 1 8 chunks +4 lines, -23 lines 0 comments Download
M src/pkg/runtime/mcache.c View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/runtime/mcentral.c View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/runtime/mem.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/mgc0.c View 1 5 chunks +6 lines, -10 lines 0 comments Download
M src/pkg/runtime/mheap.c View 1 15 chunks +138 lines, -185 lines 0 comments Download
M src/pkg/runtime/proc.c View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 5 chunks +12 lines, -3 lines 0 comments Download
M src/pkg/runtime/stack.c View 1 9 chunks +139 lines, -215 lines 0 comments Download
M src/pkg/runtime/stack_test.go View 1 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 3
khr
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
9 years, 10 months ago (2014-07-01 02:48:06 UTC) #1
khr
*** Submitted as https://code.google.com/p/go/source/detail?r=2c57aaea79c4 *** undo CL 104200047 / 318b04f28372 Breaks windows and race detector. ...
9 years, 10 months ago (2014-07-01 02:48:16 UTC) #2
gobot
9 years, 10 months ago (2014-07-01 05:03:15 UTC) #3
Message was sent while issue was closed.
This CL appears to have broken the nacl-amd64p32 builder.
See http://build.golang.org/log/96cf624ec82f6d9c3c72709db29d2686fb1cff4c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b