Issue 101550043: code review 101550043: flag: add a little more doc comment to Duration.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 101550043: code review 101550043: flag: add a little more doc comment to Duration. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by dsymonds

Modified:
10 years, 11 months ago

Reviewers:
r

CC:
r, golang-codereviews

Visibility:
Public.

Description

flag: add a little more doc comment to Duration. The only text that describes the accepted format is in the package doc, which is far away from these functions. The other flag types don't need this explicitness because they are more obvious.

Patch Set 1 #

Patch Set 2 : diff -r a6b828745f8e https://code.google.com/p/go #

Patch Set 3 : diff -r a6b828745f8e https://code.google.com/p/go #

Patch Set 4 : diff -r 90616fa61ef4 https://code.google.com/p/go #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/pkg/flag/flag.go	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 11 months ago (2014-06-28 00:17:19 UTC) #1

dsymonds

10 years, 11 months ago (2014-06-28 10:47:19 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=58d88e6bb193 ***

flag: add a little more doc comment to Duration.

The only text that describes the accepted format is in the package doc,
which is far away from these functions. The other flag types don't need
this explicitness because they are more obvious.

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/101550043

Expand All Messages | Collapse All Messages