Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(94)

Issue 10152043: Update the Charmworld api to version 2.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by rharding
Modified:
10 years, 11 months ago
Reviewers:
mp+168472, jeff.pihach
Visibility:
Public.

Description

Update the Charmworld api to version 2. - This is a purely mechanical change. Api2 create new endpoints and no functionality of the current app is currently changed. - This is meant to open the door for the related charms work and should help in performance by removing un-used bits of the current api calls. https://code.launchpad.net/~rharding/juju-gui/api2/+merge/168472 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update the Charmworld api to version 2. #

Patch Set 3 : Update the Charmworld api to version 2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -39 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/charm.js View 3 chunks +3 lines, -3 lines 0 comments Download
M app/store/charm.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M app/subapps/browser/browser.js View 2 chunks +3 lines, -3 lines 0 comments Download
M app/subapps/browser/views/charm.js View 1 chunk +1 line, -1 line 0 comments Download
M app/subapps/browser/views/charmresults.js View 1 chunk +2 lines, -2 lines 0 comments Download
M app/subapps/browser/views/view.js View 1 chunk +1 line, -1 line 0 comments Download
M docs/datasources.rst View 1 chunk +1 line, -1 line 0 comments Download
M test/test_browser_app.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_browser_charm_details.js View 8 chunks +8 lines, -8 lines 0 comments Download
M test/test_browser_editorial.js View 8 chunks +8 lines, -8 lines 0 comments Download
M test/test_browser_search_view.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_charm_store.js View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5
rharding
Please take a look.
10 years, 11 months ago (2013-06-10 15:13:04 UTC) #1
rharding
LGTM self-reviewing a purely mechanical change. Just changing instances of charmworld1 to charmworld2. All tests ...
10 years, 11 months ago (2013-06-10 15:18:09 UTC) #2
jeff.pihach
LGTM with trivial. https://codereview.appspot.com/10152043/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/10152043/diff/1/app/app.js#newcode1000 app/app.js:1000: // THIS IS BAD!!!!!!!! could probably ...
10 years, 11 months ago (2013-06-10 15:40:08 UTC) #3
rharding
Please take a look.
10 years, 11 months ago (2013-06-10 15:42:47 UTC) #4
rharding
10 years, 11 months ago (2013-06-11 14:05:02 UTC) #5
*** Submitted:

Update the Charmworld api to version 2.

- This is a purely mechanical change. Api2 create new endpoints and no
functionality of the current app is currently changed.
- This is meant to open the door for the related charms work and should help
in performance by removing un-used bits of the current api calls.

R=jeff.pihach
CC=
https://codereview.appspot.com/10152043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b