Issue 10147043: code review 10147043: goprotobuf: Fix Size for groups.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10147043: code review 10147043: goprotobuf: Fix Size for groups. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by dsymonds

Modified:
10 years, 11 months ago

Reviewers:
r

CC:
r, golang-dev

Visibility:
Public.

Description

goprotobuf: Fix Size for groups. The previous code did not account for groups at all; the test data was getting lucky. Fixes issue 38.

Patch Set 1 #

Patch Set 2 : diff -r 94487038b714 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 94487038b714 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 94487038b714 https://code.google.com/p/goprotobuf #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
M	proto/size.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	proto/size_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	proto/testdata/test.proto	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	proto/testdata/test.pb.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

10 years, 11 months ago (2013-06-10 12:44:44 UTC) #1

dsymonds

10 years, 11 months ago (2013-06-10 22:48:56 UTC) #3

*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=c80422e14e2a ***

goprotobuf: Fix Size for groups.

The previous code did not account for groups at all;
the test data was getting lucky.

Fixes issue 38.

R=r
CC=golang-dev
https://codereview.appspot.com/10147043

Expand All Messages | Collapse All Messages