code review 10113043: go.crypto: remove unreachable code.

go.crypto: remove unreachable code.

I ran go vet over all of go.crypto and removed lots of panic("unreachable") that are no longer needed.

[agl1, 2013-06-07 14:35:22]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto/

[r, 2013-06-07 15:25:20]

LGTM

[dgryski, 2013-06-07 18:22:00]

Le vendredi 7 juin 2013 16:35:22 UTC+2, agl a écrit :
>
> Reviewers: golang-dev1, 
>
> Message: 
> Hello golan...@googlegroups.com <javascript:> (cc: 
> golan...@googlegroups.com <javascript:>), 
>
> I'd like you to review this change to 
> https://code.google.com/p/go.crypto/ 
>
>
> Description: 
> go.crypto: remove unreachable code. 
>
> I ran go vet over all of go.crypto and removed lots of 
> panic("unreachable") that are no longer needed. 
>
>
> Index: curve25519/curve25519.go 
> =================================================================== 
> --- a/curve25519/curve25519.go 
> +++ b/curve25519/curve25519.go 
> @@ -4,7 +4,6 @@ 
>
>   // We have a implementation in amd64 assembly so this code is only run 
> on 
>   // non-amd64 platforms.  The amd64 assembly does not support gccgo. 
> -// +build !amd64 gccgo 
>
>   package curve25519 
>
>
This change doesn't look related.

Damian 

[agl1, 2013-06-07 18:24:11]

On Fri, Jun 7, 2013 at 2:21 PM, Damian Gryski <dgryski@gmail.com> wrote:
> This change doesn't look related.

Ah, thanks! Yes, that's working directory noise (damm mercurial). Will revert.


Cheers

AGL

[agl1, 2013-06-07 20:07:09]

*** Submitted as
https://code.google.com/p/go/source/detail?r=7f5a59ff6b43&repo=crypto ***

go.crypto: remove unreachable code.

I ran go vet over all of go.crypto and removed lots of panic("unreachable") that
are no longer needed.

R=golang-dev, r, dgryski
CC=golang-dev
https://codereview.appspot.com/10113043

[rog, 2013-06-10 12:43:56]

unfortunately this has broken our build, because we have
go.crypto as an external dependency and we cannot
move to go1.1 until some outstanding bugs are
released in 1.1.1.

might it be possible to revert this change until 1.1.1 is released?


On 7 June 2013 21:07,  <agl@golang.org> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=7f5a59ff6b43&repo=crypto
> ***
>
>
> go.crypto: remove unreachable code.
>
> I ran go vet over all of go.crypto and removed lots of
> panic("unreachable") that are no longer needed.
>
> R=golang-dev, r, dgryski
> CC=golang-dev
> https://codereview.appspot.com/10113043
>
>
> https://codereview.appspot.com/10113043/
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[agl1, 2013-06-10 14:57:34]

On Mon, Jun 10, 2013 at 8:43 AM, roger peppe <rogpeppe@gmail.com> wrote:
> unfortunately this has broken our build, because we have
> go.crypto as an external dependency and we cannot
> move to go1.1 until some outstanding bugs are
> released in 1.1.1.
>
> might it be possible to revert this change until 1.1.1 is released?

Reverted.


Cheers

AGL

[rog, 2013-06-10 15:01:32]

thanks very much

On 10 June 2013 15:57, Adam Langley <agl@golang.org> wrote:
> On Mon, Jun 10, 2013 at 8:43 AM, roger peppe <rogpeppe@gmail.com> wrote:
>> unfortunately this has broken our build, because we have
>> go.crypto as an external dependency and we cannot
>> move to go1.1 until some outstanding bugs are
>> released in 1.1.1.
>>
>> might it be possible to revert this change until 1.1.1 is released?
>
> Reverted.
>
>
> Cheers
>
> AGL