Issue 10100043: follow up issue 2470: make Completion_rest_engraver aware of completionUnit

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10100043: follow up issue 2470: make Completion_rest_engraver aware of completionUnit

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by benko.pal

Modified:
10 years, 11 months ago

Reviewers:
dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

follow up issue 2470: make Completion_rest_engraver aware of completionUnit also - extend completion unit testing to test rests too - cleanup: - fix a copy'n'paste typo - remove unused member

Patch Set 1 #

Patch Set 2 : follow up issue 3402 too #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -12 lines)			Patch
		input/regression/completion-heads-unit.ly	View		1 chunk	+4 lines, -2 lines	0 comments	Download
		lily/completion-rest-engraver.cc	View	1	8 chunks	+43 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dak

On 2013/06/06 21:19:04, benko.pal wrote: > follow up issue 3402 too The delta from patch ...

10 years, 11 months ago (2013-06-12 07:48:50 UTC) #2

benko.pal

10 years, 11 months ago (2013-06-12 11:31:58 UTC) #3

On 2013/06/12 07:48:50, dak wrote:
> On 2013/06/06 21:19:04, benko.pal wrote:
> > follow up issue 3402 too
> 
> The delta from patch set 1 to patch set 2 looks decidedly strange.  It looks
> like deleting most of the file.

um, yes.  strange.  the unified diff is as intended.

Expand All Messages | Collapse All Messages