Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(494)

Issue 10099043: code review 10099043: go.crypto/nacl/secretbox: fix append behaviour. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by agl1
Modified:
9 years, 4 months ago
Reviewers:
rsc, sfrithjof
CC:
golang-dev, sfrithjof, rsc, agl1
Visibility:
Public.

Description

go.crypto/nacl/secretbox: fix append behaviour. secretbox is supposed to append to the given slice, like hash.Sum() and append(). However, I had a complete brain-fart: I've really no idea what I was thinking of at the time.

Patch Set 1 #

Patch Set 2 : diff -r c510c3e5067d https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r c510c3e5067d https://code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r c510c3e5067d https://code.google.com/p/go.crypto/ #

Total comments: 1

Patch Set 5 : diff -r 64ed55c0ea32 https://code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -25 lines) Patch
M nacl/secretbox/secretbox.go View 1 2 5 chunks +19 lines, -25 lines 0 comments Download
M nacl/secretbox/secretbox_test.go View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/
9 years, 4 months ago (2013-06-06 20:31:09 UTC) #1
sfrithjof
I don't know if this counts, but LGTM. https://codereview.appspot.com/10099043/diff/4002/nacl/secretbox/secretbox.go File nacl/secretbox/secretbox.go (right): https://codereview.appspot.com/10099043/diff/4002/nacl/secretbox/secretbox.go#newcode48 nacl/secretbox/secretbox.go:48: head ...
9 years, 4 months ago (2013-06-07 18:36:09 UTC) #2
rsc
LGTM
9 years, 4 months ago (2013-06-10 17:42:25 UTC) #3
agl1
9 years, 4 months ago (2013-06-10 22:03:58 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=d73471ad7bea&repo=crypto ***

go.crypto/nacl/secretbox: fix append behaviour.

secretbox is supposed to append to the given slice, like hash.Sum() and
append(). However, I had a complete brain-fart: I've really no idea what
I was thinking of at the time.

R=golang-dev, sfrithjof, rsc
CC=agl, golang-dev
https://codereview.appspot.com/10099043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b