Issue 100940043: code review 100940043: runtime: fix 1-byte return during x.(T) for 0-byte T

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 100940043: code review 100940043: runtime: fix 1-byte return during x.(T) for 0-byte T (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by rsc

Modified:
10 years, 11 months ago

Reviewers:
dsymonds

CC:
golang-codereviews, dsymonds, iant, r

Visibility:
Public.

Description

runtime: fix 1-byte return during x.(T) for 0-byte T The 1-byte write was silently clearing a byte on the stack. If there was another function call with more arguments in the same stack frame, no harm done. Otherwise, if the variable at that location was already zero, no harm done. Otherwise, problems. Fixes issue 8139.

Patch Set 1 #

Patch Set 2 : diff -r 498ac2e68c28 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 498ac2e68c28 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 876107512a67 https://code.google.com/p/go/ #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -4 lines)			Patch
	M	src/pkg/runtime/iface.goc	View	1	2 chunks	+19 lines, -4 lines	0 comments	Download
	A	test/fixedbugs/issue8139.go	View	1	1 chunk	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/

10 years, 11 months ago (2014-06-03 00:34:11 UTC) #1

rsc

10 years, 11 months ago (2014-06-03 01:06:32 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=93baf7bea171 ***

runtime: fix 1-byte return during x.(T) for 0-byte T

The 1-byte write was silently clearing a byte on the stack.
If there was another function call with more arguments
in the same stack frame, no harm done.
Otherwise, if the variable at that location was already zero,
no harm done.
Otherwise, problems.

Fixes issue 8139.

LGTM=dsymonds
R=golang-codereviews, dsymonds
CC=golang-codereviews, iant, r
https://codereview.appspot.com/100940043

Expand All Messages | Collapse All Messages