Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10848)

Issue 100910043: CPP: Add "system" as a Boost component. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by roubert (google)
Modified:
9 years, 11 months ago
Reviewers:
tmancill, daniel2
Base URL:
https://libphonenumber.googlecode.com/svn/trunk
Visibility:
Public.

Description

CPP: Add "system" as a Boost component. This is required with newer Boost (starting with 1.50). R=daniel@pocock.pro BUG= Committed: https://code.google.com/p/libphonenumber/source/detail?r=667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M cpp/CMakeLists.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M debian/control View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
roubert (google)
9 years, 11 months ago (2014-06-02 15:34:47 UTC) #1
roubert (google)
Could you just comment on why / under what circumstances this is necessary, so that ...
9 years, 11 months ago (2014-06-02 15:36:24 UTC) #2
daniel2
On 02/06/14 17:36, roubert@google.com wrote: > Could you just comment on why / under what ...
9 years, 11 months ago (2014-06-02 15:37:32 UTC) #3
tmancill_debian.org
On 06/02/2014 08:37 AM, Daniel Pocock wrote: > > > On 02/06/14 17:36, roubert@google.com wrote: ...
9 years, 11 months ago (2014-06-03 05:07:08 UTC) #4
roubert (google)
On 2014/06/03 05:07:08, tmancill_debian.org wrote: > The build will fail with the current version of ...
9 years, 11 months ago (2014-06-03 08:21:54 UTC) #5
roubert (google)
9 years, 11 months ago (2014-06-03 08:23:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r667 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b