Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 10082043: code review 10082043: runtime/race: update runtime to r183418 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by dvyukov
Modified:
12 years ago
Reviewers:
iant
CC:
golang-dev, iant, remyoudompheng
Visibility:
Public.

Description

runtime/race: update runtime to r183644 This revision properly handles memory range accesses. Fixes issue 4453. Fixes issue 5654.

Patch Set 1 #

Patch Set 2 : diff -r b1217a6ca24c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r b1217a6ca24c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r b1217a6ca24c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r b1217a6ca24c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r b1217a6ca24c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r b1217a6ca24c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 8 : diff -r ae79f385177d https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 9 : diff -r ae79f385177d https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 10 : diff -r a667543bce43 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 11 : diff -r a667543bce43 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3 lines) Patch
M src/pkg/runtime/race/race_darwin_amd64.syso View 1 2 3 4 5 6 7 Binary file 0 comments Download
M src/pkg/runtime/race/race_linux_amd64.syso View 1 2 3 4 5 6 7 Binary file 0 comments Download
M src/pkg/runtime/race/race_windows_amd64.syso View 1 2 3 4 5 6 7 Binary file 0 comments Download
M src/pkg/runtime/race/testdata/mop_test.go View 1 2 3 4 5 6 7 4 chunks +39 lines, -3 lines 0 comments Download

Messages

Total messages: 8
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
12 years, 1 month ago (2013-06-06 15:46:38 UTC) #1
dvyukov
I will add linux and windows runtime tomorrow. But since there is nothing to look ...
12 years, 1 month ago (2013-06-06 15:48:38 UTC) #2
iant
Can you add a note to the CL description saying where to get the sources ...
12 years, 1 month ago (2013-06-06 17:17:05 UTC) #3
dvyukov
On Thu, Jun 6, 2013 at 9:17 PM, <iant@golang.org> wrote: > Can you add a ...
12 years, 1 month ago (2013-06-06 17:46:56 UTC) #4
iant
LGTM
12 years, 1 month ago (2013-06-06 18:07:28 UTC) #5
remyoudompheng
On 2013/06/06 15:48:38, dvyukov wrote: > I will add linux and windows runtime tomorrow. But ...
12 years, 1 month ago (2013-06-11 20:12:24 UTC) #6
dvyukov
On Wed, Jun 12, 2013 at 12:12 AM, <remyoudompheng@gmail.com> wrote: > On 2013/06/06 15:48:38, dvyukov ...
12 years, 1 month ago (2013-06-12 11:38:28 UTC) #7
dvyukov
12 years ago (2013-06-13 10:32:14 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=59ac1b0cc342 ***

runtime/race: update runtime to r183644
This revision properly handles memory range accesses.
Fixes issue 4453.
Fixes issue 5654.

R=golang-dev, iant, remyoudompheng
CC=golang-dev
https://codereview.appspot.com/10082043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b