Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 100800043: names/user: Update regex

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 12 months ago by waigani
Modified:
9 years, 12 months ago
Reviewers:
mp+220896, fwereade
Visibility:
Public.

Description

names/user: Update regex Update username regex to allow launchpad usernames, which use the following regex: r"^[a-z0-9][a-z0-9\+\.\-]+$" https://code.launchpad.net/~waigani/juju-core/change-user-regex/+merge/220896 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M names/user.go View 1 chunk +1 line, -1 line 0 comments Download
M names/user_test.go View 2 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 3
waigani
Please take a look.
9 years, 12 months ago (2014-05-26 02:23:54 UTC) #1
fwereade
What's the motivation here?
9 years, 12 months ago (2014-05-26 07:11:46 UTC) #2
fwereade
9 years, 12 months ago (2014-05-27 13:23:02 UTC) #3
On 2014/05/26 07:11:46, fwereade wrote:
> What's the motivation here?

We discussed this, but I don't recall what conclusion we came to. IMO this is
the internal juju name, and we don't want to let external auth providers affect
it -- we can't just keep on changing the regex as we get new ones. I'm open to
the idea that we want a *different* regex, but I think that's about the display
name for juju (and depends on the schema change to use something else as the
_id, I think). WIP for now?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b