code review 10078047: run.bash: raise ulimit for the number of threads.

run.bash: raise ulimit for the number of threads.

This is needed on NetBSD-current. Support for
ulimit -T in bash was added in 4.2nb3.

[bsiegert, 2013-06-09 19:10:47]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[minux1, 2013-06-09 20:54:56]

https://codereview.appspot.com/10078047/diff/5001/src/run.bash
File src/run.bash (right):

https://codereview.appspot.com/10078047/diff/5001/src/run.bash#newcode23
src/run.bash:23: [ "$(ulimit -H -T)" == "unlimited" ] || ulimit -S -T $(ulimit
-H -T)
how about this:
# NetBSD 7 introduces ...... (background info here)
ulimit -T &>/dev/null && { [ "$(ulimit -H -T)" == "unlimited" ] || ulimit -S -T
$(ulimit -H -T); }

[rsc, 2013-06-10 17:51:35]

LGTM

https://codereview.appspot.com/10078047/diff/5001/src/run.bash
File src/run.bash (right):

https://codereview.appspot.com/10078047/diff/5001/src/run.bash#newcode23
src/run.bash:23: [ "$(ulimit -H -T)" == "unlimited" ] || ulimit -S -T $(ulimit
-H -T)
On 2013/06/09 20:54:56, minux wrote:
> how about this:
> # NetBSD 7 introduces ...... (background info here)
> ulimit -T &>/dev/null && { [ "$(ulimit -H -T)" == "unlimited" ] || ulimit -S
-T
> $(ulimit -H -T); }

Please add a short comment, like
# NetBSD 7 thread count limit.
Please don't use Minux's rewrite. The if statement is clearer.

[bsiegert, 2013-06-10 19:27:41]

Hello golang-dev@googlegroups.com, minux.ma@gmail.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bsiegert, 2013-06-10 19:27:57]

https://codereview.appspot.com/10078047/diff/5001/src/run.bash
File src/run.bash (right):

https://codereview.appspot.com/10078047/diff/5001/src/run.bash#newcode23
src/run.bash:23: [ "$(ulimit -H -T)" == "unlimited" ] || ulimit -S -T $(ulimit
-H -T)
On 2013/06/10 17:51:36, rsc wrote:
> On 2013/06/09 20:54:56, minux wrote:
> > how about this:
> > # NetBSD 7 introduces ...... (background info here)
> > ulimit -T &>/dev/null && { [ "$(ulimit -H -T)" == "unlimited" ] || ulimit -S
> -T
> > $(ulimit -H -T); }
> 
> Please add a short comment, like
> # NetBSD 7 thread count limit.
> Please don't use Minux's rewrite. The if statement is clearer.

Done. I used the &> form though.

[minux1, 2013-06-10 20:18:06]

LGTM.

[dave_cheney.net, 2013-06-14 23:59:56]

On 2013/06/10 20:18:06, minux wrote:
> LGTM.

ping.

[bsiegert, 2013-06-17 09:20:09]

I still do not have submit privileges. Could somebody submit this for me?

[dave_cheney.net, 2013-06-17 09:21:09]

Oh, sorry Benny. I'll do that now.

On Mon, Jun 17, 2013 at 7:20 PM,  <bsiegert@gmail.com> wrote:
> I still do not have submit privileges. Could somebody submit this for
> me?
>
> https://codereview.appspot.com/10078047/

[dave_cheney.net, 2013-06-17 09:33:04]

*** Submitted as https://code.google.com/p/go/source/detail?r=f5f5eb2a5b8b ***

run.bash: raise ulimit for the number of threads.

This is needed on NetBSD-current. Support for
ulimit -T in bash was added in 4.2nb3.

R=golang-dev, minux.ma, rsc, dave
CC=golang-dev
https://codereview.appspot.com/10078047

Committer: Dave Cheney <dave@cheney.net>