code review 10057044: cmd/gc: move genembedtramp into portable code

cmd/gc: move genembedtramp into portable code

Requires adding new linker instruction
        RET	f(SB)
meaning return but then immediately call f.
This is what you'd use to implement a tail call after
fiddling with the arguments, but the compiler only
uses it in genwrapper.

This CL eliminates the copy-and-paste genembedtramp
functions from 5g/8g/6g and makes the code run on ARM
for the first time. It removes a small special case for function
generation, which should help Carl a bit, but at the same time
it does not bother to implement general tail call optimization,
which we do not want anyway.

Fixes issue 5627.

[rsc, 2013-06-11 13:41:46]

Hello ken2 (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2013-06-11 13:41:53]

*** Submitted as https://code.google.com/p/go/source/detail?r=4fb5b9ee0f0c ***

cmd/gc: move genembedtramp into portable code

Requires adding new linker instruction
        RET	f(SB)
meaning return but then immediately call f.
This is what you'd use to implement a tail call after
fiddling with the arguments, but the compiler only
uses it in genwrapper.

This CL eliminates the copy-and-paste genembedtramp
functions from 5g/8g/6g and makes the code run on ARM
for the first time. It removes a small special case for function
generation, which should help Carl a bit, but at the same time
it does not bother to implement general tail call optimization,
which we do not want anyway.

Fixes issue 5627.

R=ken2
CC=golang-dev
https://codereview.appspot.com/10057044

[dave_cheney.net, 2013-06-11 13:58:38]

Sorry rsc, this has upset the -race builders.

On Tue, Jun 11, 2013 at 11:41 PM,  <rsc@golang.org> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=4fb5b9ee0f0c ***
>
>
> cmd/gc: move genembedtramp into portable code
>
> Requires adding new linker instruction
>         RET     f(SB)
> meaning return but then immediately call f.
> This is what you'd use to implement a tail call after
> fiddling with the arguments, but the compiler only
> uses it in genwrapper.
>
> This CL eliminates the copy-and-paste genembedtramp
> functions from 5g/8g/6g and makes the code run on ARM
> for the first time. It removes a small special case for function
> generation, which should help Carl a bit, but at the same time
> it does not bother to implement general tail call optimization,
> which we do not want anyway.
>
> Fixes issue 5627.
>
> R=ken2
> CC=golang-dev
> https://codereview.appspot.com/10057044
>
>
> https://codereview.appspot.com/10057044/
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>