Issue 10051046: code review 10051046: go.net/ipv6: disable tests on non-ipv6 kernels

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10051046: code review 10051046: go.net/ipv6: disable tests on non-ipv6 kernels (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by mikio

Modified:
11 years, 9 months ago

Reviewers:
r, capnm

CC:
dave_cheney.net, capnm, golang-dev

Visibility:
Public.

Description

go.net/ipv6: disable tests on non-ipv6 kernels

Patch Set 2 : diff -r 481670f799b5 https://code.google.com/p/go.net #

Patch Set 3 : diff -r 481670f799b5 https://code.google.com/p/go.net #

Patch Set 4 : diff -r 481670f799b5 https://code.google.com/p/go.net #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -0 lines)			Patch
M	ipv6/icmp_test.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ipv6/multicast_test.go	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	ipv6/multicastlistener_test.go	View	1	4 chunks	+12 lines, -0 lines	0 comments	Download
M	ipv6/multicastsockopt_test.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ipv6/sockopt_test.go	View	1	4 chunks	+18 lines, -0 lines	0 comments	Download
M	ipv6/unicast_test.go	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	ipv6/unicastsockopt_test.go	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mikio

Hello dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

11 years, 9 months ago (2013-06-06 00:46:41 UTC) #1

capnm

LGTM My rpi build bot is happy (I guess they disabled ipv6 support for performance ...

11 years, 9 months ago (2013-06-06 05:46:35 UTC) #2

mikio

*** Submitted as https://code.google.com/p/go/source/detail?r=18808b83b019&repo=net *** go.net/ipv6: disable tests on non-ipv6 kernels R=dave, capnm9 CC=golang-dev https://codereview.appspot.com/10051046

11 years, 9 months ago (2013-06-06 08:12:28 UTC) #3

LGTM Please don't submit CLs without an LGTM from an established team member.

11 years, 9 months ago (2013-06-06 13:04:26 UTC) #4

mikio

11 years, 9 months ago (2013-06-06 13:49:17 UTC) #5

On Thu, Jun 6, 2013 at 10:04 PM,  <r@golang.org> wrote:

> Please don't submit CLs without an LGTM from an established team member.

Sorry about that.

Expand All Messages | Collapse All Messages