Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2368)

Issue 10049046: Fix CI failures.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by frankban
Modified:
10 years, 10 months ago
Reviewers:
mp+168966, matthew.scott, gary.poster
Visibility:
Public.

Description

Fix CI failures. This branch tries to fix current CI failures: a BadStatusLine exception is raised in ie due to a disconnection caused by the element.click() call. Subsequent tests in the same testcase fail as well, because the driver is no longer alive. AFAICT this is a new weird ie behavior: added a workaround to fix that. Our test messages are now printed to stderr: I'd like to see if this fixes the Jenkins output, that seems quite confusing to me. https://code.launchpad.net/~frankban/juju-gui/ci-deploy-failure/+merge/168966 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix CI failures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -20 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M test/browser.py View 10 chunks +32 lines, -10 lines 0 comments Download
M test/test_charm_running.py View 6 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
10 years, 10 months ago (2013-06-12 14:39:17 UTC) #1
matthew.scott
LGTM, thanks for finding a work around. I'm not a fan of having to do ...
10 years, 10 months ago (2013-06-12 14:57:12 UTC) #2
gary.poster
LGTM. Thank you very much.
10 years, 10 months ago (2013-06-12 15:58:36 UTC) #3
frankban
*** Submitted: Fix CI failures. This branch tries to fix current CI failures: a BadStatusLine ...
10 years, 10 months ago (2013-06-12 16:04:43 UTC) #4
frankban
10 years, 10 months ago (2013-06-12 16:11:39 UTC) #5
Thank you both for the reviews.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b