Pan to services on delta.

Pan to services on delta.

On the first delta, pan to the service(s).  On subsequent service creation, zoom to the service(s), including the ghost service (this prevents a ghost service from being created outside of the viewport).  This behavior simply pans to the centroid of the convex hull of services and does not move any services itself, meaning that one might still see an empty canvas if services are moved in a wide-diameter ring.  However, this should still help maintain focus on the services.

https://code.launchpad.net/~makyo/juju-gui/zoom-to-delta/+merge/167564

(do not edit description out of merge proposal)

[matthew.scott, 2013-06-05 15:10:25]

Please take a look.

[matthew.scott, 2013-06-05 15:24:06]

Please take a look.

[jeff.pihach, 2013-06-05 15:46:50]

Thanks for this LGTM will QA now.

https://codereview.appspot.com/10048043/diff/1/app/config-debug.js
File app/config-debug.js (right):

https://codereview.appspot.com/10048043/diff/1/app/config-debug.js#newcode45
app/config-debug.js:45: sandbox: false,
You probably didn't intend on committing this change.

https://codereview.appspot.com/10048043/diff/1/app/views/topology/panzoom.js
File app/views/topology/panzoom.js (right):

https://codereview.appspot.com/10048043/diff/1/app/views/topology/panzoom.js#...
app/views/topology/panzoom.js:245: var topo = this.get('component'),
Any chance you could add these attributes to the attrs below and document them?

[matthew.scott, 2013-06-05 16:58:54]

https://codereview.appspot.com/10048043/diff/1/app/views/topology/panzoom.js
File app/views/topology/panzoom.js (right):

https://codereview.appspot.com/10048043/diff/1/app/views/topology/panzoom.js#...
app/views/topology/panzoom.js:245: var topo = this.get('component'),
On 2013/06/05 15:46:50, jeff.pihach wrote:
> Any chance you could add these attributes to the attrs below and document
them?

Done.

[matthew.scott, 2013-06-05 17:01:52]

Please take a look.

[benjamin.saller, 2013-06-05 18:06:38]

This is pretty cool. I've noticed an issue with zoom level interaction. I spent
a few minutes trying to get you a patch but don't have one yet. Is this
something you'd like to look at? I added the following to findAndSetCentroid to
ease debugging, you might find it helpful as well.

   topo.vis.selectAll('.debug').remove();
      topo.vis.append('polyline')
            .attr({
              'points': d3.geom.hull(vertices),
              'class': 'debug',
              'stroke': 'blue',
              'fill': 'white',
              'opacity': '0.4',
             'stroke-width': '2px'});
        topo.vis.append('circle')
            .attr({
              'class': 'debug',
              'cx': centroid[0],
              'cy': centroid[1],
              fill: 'red',
              opacity: '0.4',
              r: '5px'
            });
         topo.vis.append('circle')
            .attr({
              'class': 'debug',
              'cx': 0,
              'cy': 1,
              fill: 'green',
              opacity: '0.4',
              r: '5px'
            });

[matthew.scott, 2013-06-07 19:54:04]

Please take a look.

[teknico, 2013-06-11 16:25:12]

LGTM, nice improvement.

[matthew.scott, 2013-06-11 17:27:59]

*** Submitted:

Pan to services on delta.

On the first delta, pan to the service(s).  On subsequent service creation, zoom
to the service(s), including the ghost service (this prevents a ghost service
from being created outside of the viewport).  This behavior simply pans to the
centroid of the convex hull of services and does not move any services itself,
meaning that one might still see an empty canvas if services are moved in a
wide-diameter ring.  However, this should still help maintain focus on the
services.

R=jeff.pihach, benjamin.saller, teknico
CC=
https://codereview.appspot.com/10048043