Issue 100480046: code review 100480046: x86asm: sign-extend values but print them unsigned

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 100480046: code review 100480046: x86asm: sign-extend values but print them unsigned (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by josharian

Modified:
9 years, 3 months ago

Reviewers:
rsc

Visibility:
Public.

Description

x86asm: sign-extend values but print them unsigned Fixes issue 8000.

Patch Set 1 #

Patch Set 2 : diff -r de24a08ee5e0 https://code.google.com/p/rsc.x86 #

Patch Set 3 : diff -r de24a08ee5e0 https://code.google.com/p/rsc.x86 #

Patch Set 4 : diff -r de24a08ee5e0 https://code.google.com/p/rsc.x86 #

Patch Set 5 : diff -r de24a08ee5e0 https://code.google.com/p/rsc.x86 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -42 lines)			Patch
M	x86asm/decode.go	View	1 2 3	7 chunks	+9 lines, -9 lines	0 comments	Download
M	x86asm/ext_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	x86asm/gnu.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	x86asm/inst.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	x86asm/intel.go	View	1	2 chunks	+4 lines, -5 lines	0 comments	Download
M	x86asm/plan9x.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	x86asm/testdata/decode.txt	View	1	6 chunks	+24 lines, -21 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

josharian

Hello rsc@golang.org, I'd like you to review this change to https://code.google.com/p/rsc.x86

9 years, 10 months ago (2014-06-11 01:10:02 UTC) #1

josharian

9 years, 10 months ago (2014-06-11 01:14:33 UTC) #2

I'm not super confident in these changes.

* I changed all the conversions in decode.go to sign-extend, but I wasn't able
to confirm that all the underlying values are in fact signed. I hoped that the
unit tests would clarify, or that you would know offhand.

* I can't run the full unit tests due to not having the requisite binaries.

* The short unit tests were failing before this CL:

--- FAIL: TestDecode (0.02 seconds)
	decode_test.go:68: Decode(3667f3660ff7c0|11223344556677885f) [gnu] = ss, 1,
want ss addr32 rep maskmovdqu %xmm0,%xmm0, 7

Expand All Messages | Collapse All Messages