Issue 10046047: revert r1257 due to a failing test:

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10046047: revert r1257 due to a failing test: (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by dimitern

Modified:
10 years, 10 months ago

Reviewers:
gz, mp+168018

Visibility:
Public.

Description

revert r1257 due to a failing test: https://bugs.launchpad.net/juju-core/+bug/1188549 https://code.launchpad.net/~dimitern/juju-core/058-revert-r1257/+merge/168018 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : revert r1257 due to a failing test: #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -502 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/addmachine.go	View	4 chunks	+5 lines, -40 lines	0 comments	Download
M	cmd/juju/addmachine_test.go	View	2 chunks	+0 lines, -41 lines	0 comments	Download
D	state/container.go	View	1 chunk	+0 lines, -91 lines	0 comments	Download
M	state/machine.go	View	6 chunks	+11 lines, -43 lines	0 comments	Download
M	state/machine_test.go	View	3 chunks	+0 lines, -21 lines	0 comments	Download
M	state/open.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	state/state.go	View	6 chunks	+21 lines, -97 lines	0 comments	Download
M	state/state_test.go	View	4 chunks	+4 lines, -119 lines	0 comments	Download
M	state/unit.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/watcher.go	View	2 chunks	+7 lines, -23 lines	0 comments	Download
M	worker/provisioner/provisioner.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	worker/provisioner/provisioner_test.go	View	1 chunk	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM Ian, to reland your branch, do: bzr merge lp:~dimitern/juju-core/058-revert-r1257 bzr revert * bzr commit ...

10 years, 10 months ago (2013-06-07 11:24:54 UTC) #2

dimitern

10 years, 10 months ago (2013-06-07 11:27:04 UTC) #3

*** Submitted:

revert r1257 due to a failing test:

https://bugs.launchpad.net/juju-core/+bug/1188549

R=gz
CC=
https://codereview.appspot.com/10046047

Expand All Messages | Collapse All Messages