Issue 100440045: code review 100440045: cmd/addr2line,cmd/objdump: test that commands accept ad...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 100440045: code review 100440045: cmd/addr2line,cmd/objdump: test that commands accept ad... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 12 months ago by brainman

Modified:
10 years, 12 months ago

Reviewers:
gobot, iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

cmd/addr2line,cmd/objdump: test that commands accept addresses with 0x prefix and without

Patch Set 1 #

Patch Set 2 : diff -r 391d6d71c738 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 391d6d71c738 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e48bff80e345 https://go.googlecode.com/hg/ #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -39 lines)			Patch
	M	src/cmd/addr2line/addr2line_test.go	View	1	2 chunks	+26 lines, -19 lines	0 comments	Download
	M	src/cmd/objdump/objdump_test.go	View	1 2 3	3 chunks	+26 lines, -20 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 12 months ago (2014-05-14 07:45:52 UTC) #1

brainman

*** Submitted as https://code.google.com/p/go/source/detail?r=b10044024a6d *** cmd/addr2line,cmd/objdump: test that commands accept addresses with 0x prefix and ...

10 years, 12 months ago (2014-05-15 05:55:38 UTC) #3

gobot

10 years, 12 months ago (2014-05-15 10:37:41 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the freebsd-arm-cheney builder.
See http://build.golang.org/log/f6bfd7e5813ae7a25ec7a22babe8ca0b6893610f

Expand All Messages | Collapse All Messages