Issue 10042043: code review 10042043: go.net/ipv6: fix typo

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10042043: code review 10042043: go.net/ipv6: fix typo (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by mikio

Modified:
11 years, 10 months ago

Reviewers:
dave

CC:
dave_cheney.net, golang-dev

Visibility:
Public.

Description

go.net/ipv6: remove RawConn reference from package documentation This package doesn't have RawConn type.

Patch Set 1 #

Patch Set 2 : diff -r 2893ed4717f2 https://code.google.com/p/go.net #

Patch Set 3 : diff -r 2893ed4717f2 https://code.google.com/p/go.net #

Total comments: 2

Patch Set 4 : diff -r 38585c3e6491 https://code.google.com/p/go.net #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	ipv6/doc.go	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

11 years, 10 months ago (2013-06-05 09:01:35 UTC) #1

dave_cheney.net

LGTM. I suggest changing the description to go.net/ipv6: remove RawConn reference from package documentation. https://codereview.appspot.com/10042043/diff/5001/ipv6/doc.go ...

11 years, 10 months ago (2013-06-05 09:07:42 UTC) #2

mikio

11 years, 10 months ago (2013-06-05 09:27:50 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=e9ac3861bbb0&repo=net ***

go.net/ipv6: remove RawConn reference from package documentation

This package doesn't have RawConn type.

R=dave
CC=golang-dev
https://codereview.appspot.com/10042043

https://codereview.appspot.com/10042043/diff/5001/ipv6/doc.go
File ipv6/doc.go (right):

https://codereview.appspot.com/10042043/diff/5001/ipv6/doc.go#newcode141
ipv6/doc.go:141: // by using:
On 2013/06/05 09:07:42, dfc wrote:
> Is it more correct to say
> 
> // An application that uses PacketConn may join multiple group addresses. 
> 

Done.

Expand All Messages | Collapse All Messages