Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 10030043: code review 10030043: libmach: support more 386/amd64 instructions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by ality
Modified:
11 years, 8 months ago
Reviewers:
rsc
CC:
golang-dev, dave_cheney.net, bradfitz, rsc
Visibility:
Public.

Description

libmach: support more 386/amd64 instructions

Patch Set 1 #

Patch Set 2 : diff -r 6ec8c49421a0 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6ec8c49421a0 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 3aa62752e9a2 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 372ae572457a https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -76 lines) Patch
M src/libmach/8db.c View 1 2 3 13 chunks +116 lines, -76 lines 0 comments Download

Messages

Total messages: 7
ality
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 10 months ago (2013-06-05 00:26:28 UTC) #1
dave_cheney.net
On 2013/06/05 00:26:28, ality wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
11 years, 9 months ago (2013-06-17 10:31:39 UTC) #2
bradfitz
R=rsc
11 years, 9 months ago (2013-06-17 20:20:22 UTC) #3
rsc
LGTM
11 years, 9 months ago (2013-06-21 17:36:09 UTC) #4
dave_cheney.net
On 2013/06/21 17:36:09, rsc wrote: > LGTM ality - ping, you're good to land this.
11 years, 9 months ago (2013-06-25 02:19:58 UTC) #5
ality
dave@cheney.net once said: > ality - ping, you're good to land this. I'll land it ...
11 years, 9 months ago (2013-06-27 11:25:26 UTC) #6
ality
11 years, 8 months ago (2013-07-20 07:38:35 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=ee11148d2255 ***

libmach: support more 386/amd64 instructions

R=golang-dev, dave, bradfitz, rsc
CC=golang-dev
https://codereview.appspot.com/10030043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b