code review 10023043: build: add intptr typedef for Plan 9

build: add intptr typedef for Plan 9

Revision 01810e5c68e9 added the following to src/pkg/runtime/stack.h:

        StackPreempt = (uintptr)(intptr)0xffffade,

The typedef for intptr is defined in two places:

        1. src/pkg/runtime/runtime.h for use by the runtime

        2. include/u.h for use by the compilers and linkers

On Plan 9, we don't use include/u.h but instead augment the host's
u.h with extra typedefs. These are in include/plan9/GOARCH/u.h.

We forgot to add intptr. It didn't cause a problem until now since
that typedef was never used outside the runtime.

[ality, 2013-06-04 22:49:31]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-06-04 22:58:31]

LGTM



On Tue, Jun 4, 2013 at 3:49 PM, <ality@pbrane.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> build: add intptr typedef for Plan 9
>
> Revision 01810e5c68e9 added the following to src/pkg/runtime/stack.h:
>
>         StackPreempt = (uintptr)(intptr)0xffffade,
>
> The typedef for intptr is defined in two places:
>
>         1. src/pkg/runtime/runtime.h for use by the runtime
>
>         2. include/u.h for use by the compilers and linkers
>
> On Plan 9, we don't use include/u.h but instead augment the host's
> u.h with extra typedefs. These are in include/plan9/GOARCH/u.h.
>
> We forgot to add intptr. It didn't cause a problem until now since
> that typedef was never used outside the runtime.
>
> Please review this at
https://codereview.appspot.**com/10023043/<https://codereview.appspot.com/100...
>
> Affected files:
>   M include/plan9/386/u.h
>   M include/plan9/amd64/u.h
>   M include/plan9/arm/u.h
>
>
> Index: include/plan9/386/u.h
> ==============================**==============================**=======
> --- a/include/plan9/386/u.h
> +++ b/include/plan9/386/u.h
> @@ -4,11 +4,12 @@
>
>  #include "/386/include/u.h"
>
> -typedef char   int8;
> -typedef uchar  uint8;
> -typedef short  int16;
> -typedef ushort uint16;
> -typedef int    int32;
> -typedef uint   uint32;
> -typedef vlong  int64;
> -typedef uvlong uint64;
> +typedef        char    int8;
> +typedef        uchar   uint8;
> +typedef        short   int16;
> +typedef        ushort  uint16;
> +typedef        int     int32;
> +typedef        uint    uint32;
> +typedef        vlong   int64;
> +typedef        uvlong  uint64;
> +typedef        int     intptr;
> Index: include/plan9/amd64/u.h
> ==============================**==============================**=======
> --- a/include/plan9/amd64/u.h
> +++ b/include/plan9/amd64/u.h
> @@ -4,11 +4,12 @@
>
>  #include "/amd64/include/u.h"
>
> -typedef char   int8;
> -typedef uchar  uint8;
> -typedef short  int16;
> -typedef ushort uint16;
> -typedef int    int32;
> -typedef uint   uint32;
> -typedef vlong  int64;
> -typedef uvlong uint64;
> +typedef        char    int8;
> +typedef        uchar   uint8;
> +typedef        short   int16;
> +typedef        ushort  uint16;
> +typedef        int     int32;
> +typedef        uint    uint32;
> +typedef        vlong   int64;
> +typedef        uvlong  uint64;
> +typedef        vlong   intptr;
> Index: include/plan9/arm/u.h
> ==============================**==============================**=======
> --- a/include/plan9/arm/u.h
> +++ b/include/plan9/arm/u.h
> @@ -4,11 +4,12 @@
>
>  #include "/arm/include/u.h"
>
> -typedef char   int8;
> -typedef uchar  uint8;
> -typedef short  int16;
> -typedef ushort uint16;
> -typedef int    int32;
> -typedef uint   uint32;
> -typedef vlong  int64;
> -typedef uvlong uint64;
> +typedef        char    int8;
> +typedef        uchar   uint8;
> +typedef        short   int16;
> +typedef        ushort  uint16;
> +typedef        int     int32;
> +typedef        uint    uint32;
> +typedef        vlong   int64;
> +typedef        uvlong  uint64;
> +typedef        int     intptr;
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[ality, 2013-06-04 23:21:13]

*** Submitted as https://code.google.com/p/go/source/detail?r=dd6cd9d1be17 ***

build: add intptr typedef for Plan 9

Revision 01810e5c68e9 added the following to src/pkg/runtime/stack.h:

        StackPreempt = (uintptr)(intptr)0xffffade,

The typedef for intptr is defined in two places:

        1. src/pkg/runtime/runtime.h for use by the runtime

        2. include/u.h for use by the compilers and linkers

On Plan 9, we don't use include/u.h but instead augment the host's
u.h with extra typedefs. These are in include/plan9/GOARCH/u.h.

We forgot to add intptr. It didn't cause a problem until now since
that typedef was never used outside the runtime.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/10023043

[rsc, 2013-06-10 19:31:43]

This change should be reverted. It encourages bad code, such as the code that
now compiles.