Issue 100230043: code review 100230043: runtime: optimize markspan

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 100230043: code review 100230043: runtime: optimize markspan (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by dvyukov

Modified:
11 years, 7 months ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

runtime: optimize markspan Increases throughput by 2x on a memory hungry program on 8-node NUMA machine.

Patch Set 1 #

Patch Set 2 : diff -r d797b2316601 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r ad0ee2227396 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r ad0ee2227396 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r ad0ee2227396 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	src/pkg/runtime/mgc0.c	View	1 2 3	3 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 7 months ago (2014-05-07 15:15:17 UTC) #1

rsc

LGTM Because this is such a trivial change causing such a significant performance improvement (on ...

11 years, 7 months ago (2014-05-07 15:26:01 UTC) #2

dvyukov

*** Submitted as https://code.google.com/p/go/source/detail?r=dd962f500bed *** runtime: optimize markspan Increases throughput by 2x on a memory ...

11 years, 7 months ago (2014-05-07 15:32:37 UTC) #3

gobot

11 years, 7 months ago (2014-05-07 15:52:29 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the openbsd-amd64-rootbsd builder.
See http://build.golang.org/log/a7bedd92513e629acb55e7a009ca8dbb2fa23d5e

Expand All Messages | Collapse All Messages