Issue 10022043: Fix trunk so it builds and runs tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10022043: Fix trunk so it builds and runs tests

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by thumper

Modified:
11 years, 9 months ago

Reviewers:
mp+167418, wallyworld

Visibility:
Public.

Description

Fix trunk so it builds and runs tests r1247 introduced a regression to MachineSuite.TestServeAPI in cmd/jujud/machine_test.go It was not obvious to me in five minutes how to make the test still test what it should, so I have disabled the test by commenting it out, and left a TODO with the original branch author to either fix the test or delete it. https://code.launchpad.net/~thumper/juju-core/fix-trunk-break/+merge/167418 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix trunk so it builds and runs tests #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -32 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	cmd/jujud/machine_test.go	View		1 chunk	+35 lines, -32 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

thumper

11 years, 9 months ago (2013-06-04 23:04:25 UTC) #3

*** Submitted:

Fix trunk so it builds and runs tests

r1247 introduced a regression to MachineSuite.TestServeAPI in
cmd/jujud/machine_test.go It was not obvious to me in five minutes how to make
the test still test what it should, so I have disabled the test by commenting
it out, and left a TODO with the original branch author to either fix the test
or delete it.

R=wallyworld
CC=
https://codereview.appspot.com/10022043

Expand All Messages | Collapse All Messages