Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(137)

Issue 100210043: code review 100210043: test/bench/shootout: support windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by chai2010
Modified:
10 years, 8 months ago
Reviewers:
iant
CC:
golang-codereviews, iant
Visibility:
Public.

Description

test/bench/shootout: support windows 1. fix executable extension (a.out -> a.exe). 2. fix pthread build error on mingw 3. if depends lib messing, skip the test

Patch Set 1 #

Patch Set 2 : diff -r f96d3354edb6 https://code.google.com/p/go/ #

Patch Set 3 : diff -r f96d3354edb6 https://code.google.com/p/go/ #

Patch Set 4 : diff -r f96d3354edb6 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -64 lines) Patch
M test/bench/shootout/threadring.c View 1 2 chunks +11 lines, -1 line 0 comments Download
M test/bench/shootout/timing.sh View 1 3 chunks +94 lines, -63 lines 0 comments Download

Messages

Total messages: 5
chai2010
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years ago (2014-05-07 10:19:09 UTC) #1
iant
LGTM Have you verified that the script still runs on GNU/Linux?
11 years ago (2014-05-07 13:35:53 UTC) #2
chai2010
On 2014/05/07 13:35:53, iant wrote: > LGTM > > Have you verified that the script ...
11 years ago (2014-05-07 23:35:06 UTC) #3
iant
LGTM I tested it and it still works.
11 years ago (2014-05-09 21:34:42 UTC) #4
iant
11 years ago (2014-05-09 21:34:53 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=0997352b5359 ***

test/bench/shootout: support windows

1. fix executable extension (a.out -> a.exe).
2. fix pthread build error on mingw
3. if depends lib messing, skip the test

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/100210043

Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b