Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2591)

Issue 10020044: Fix backend unit tests.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by teknico
Modified:
10 years, 10 months ago
Reviewers:
bac, frankban, mp+167742
Visibility:
Public.

Description

Fix backend unit tests. Make the backend unit tests not expect any extra repositories. https://code.launchpad.net/~teknico/charms/precise/juju-gui/fix-unit-tests/+merge/167742 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix backend unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M revision View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/test_backends.py View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5
teknico
Please take a look.
10 years, 10 months ago (2013-06-06 11:34:46 UTC) #1
frankban
LGTM, with a request and a suggestion: - please increase the charm revision number; - ...
10 years, 10 months ago (2013-06-06 12:10:44 UTC) #2
teknico
frankban wrote: > LGTM, with a request and a suggestion: > > - please increase ...
10 years, 10 months ago (2013-06-06 13:20:28 UTC) #3
bac
LGTM. I also like Francesco's suggestion about comparing for an empty set even with the ...
10 years, 10 months ago (2013-06-06 13:46:38 UTC) #4
teknico
10 years, 10 months ago (2013-06-06 13:55:45 UTC) #5
*** Submitted:

Fix backend unit tests.

Make the backend unit tests not expect any extra repositories.

R=frankban, bac
CC=
https://codereview.appspot.com/10020044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b