Issue 10019049: Fix machine tag for containers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10019049: Fix machine tag for containers (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by wallyworld

Modified:
10 years, 10 months ago

Reviewers:
mp+168825, thumper

Visibility:
Public.

Description

Fix machine tag for containers Container ids can't be used in file names since they contain "/". Replace the "/" with a "-". https://code.launchpad.net/~wallyworld/juju-core/container-tag/+merge/168825 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix machine tag for containers #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/machine.go	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	state/machine_test.go	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

thumper

On 2013/06/11 22:25:52, wallyworld wrote: > Please take a look. LGTM - trivial

10 years, 10 months ago (2013-06-11 22:28:45 UTC) #2

wallyworld

10 years, 10 months ago (2013-06-11 22:45:21 UTC) #3

*** Submitted:

Fix machine tag for containers

Container ids can't be used in file names since they contain "/".
Replace the "/" with a "-".

R=thumper
CC=
https://codereview.appspot.com/10019049

Expand All Messages | Collapse All Messages