Issue 100130045: PS social links handled same way as email and phone links

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 100130045: PS social links handled same way as email and phone links

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by prannoysircar0325

Modified:
9 years, 11 months ago

Reviewers:
mail2coolgarg

Base URL:
https://immpandroid.unfuddle.com/svn/immpandroid_android/spfaq/

Visibility:
Public.

More Reviews

Description

PS social links handled same way as email and phone links

Patch Set 1 #

Total comments: 3

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+235 lines, -32 lines)			Patch
M	project.properties	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A	res/layout/social_site_layout.xml	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	res/values/arrays.xml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	res/values/strings.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/app/shoppoke/faq/qa/StoreContactInformationHandler.java	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/app/shoppoke/faq/qa/StoreContactInformationResponse.java	View	1 chunk	+31 lines, -27 lines	0 comments	Download
A	src/app/shoppoke/faq/storedetail/SocialSitesListHandler.java	View	1 chunk	+74 lines, -0 lines	0 comments	Download
A	src/app/shoppoke/faq/storedetail/SocialSitesUrl.java	View	1 chunk	+99 lines, -0 lines	3 comments	Download
M	src/app/shoppoke/faq/storedetail/StoreDetailActivity.java	View	3 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

mail2coolgarg

9 years, 11 months ago (2014-05-06 11:38:15 UTC) #1

please fix comments.

https://codereview.appspot.com/100130045/diff/1/src/app/shoppoke/faq/storedet...
File src/app/shoppoke/faq/storedetail/SocialSitesUrl.java (right):

https://codereview.appspot.com/100130045/diff/1/src/app/shoppoke/faq/storedet...
src/app/shoppoke/faq/storedetail/SocialSitesUrl.java:15: public class
SocialSitesUrl extends BaseResponseObject {
missing @Databasetable

https://codereview.appspot.com/100130045/diff/1/src/app/shoppoke/faq/storedet...
src/app/shoppoke/faq/storedetail/SocialSitesUrl.java:64: public static
DBUtil<SocialSitesUrl> getPHDBUtil(Context activity) {
 getPHDBUtil => getDBUtil

https://codereview.appspot.com/100130045/diff/1/src/app/shoppoke/faq/storedet...
src/app/shoppoke/faq/storedetail/SocialSitesUrl.java:96:
getPHDBUtil(activity).callBatchInsertUpdates(socialSitesList);
Line 96 is unnecessary.

Expand All Messages | Collapse All Messages