code review 10005044: cmd/cc: emit size of locals. Will be used for stack co...

cmd/cc: emit size of locals.  Will be used for stack copying.

[khr, 2013-06-10 19:34:05]

Hello cshapiro (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://khr%40golang.org@code.google.com/p/go/

[dvyukov, 2013-06-10 19:41:25]

On Mon, Jun 10, 2013 at 11:34 PM,  <khr@golang.org> wrote:
> Reviewers: cshapiro,
>
> Message:
> Hello cshapiro (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://khr%40golang.org@code.google.com/p/go/
>
>
> Description:
> cmd/cc: emit size of locals.  Will be used for stack copying.
>
> Please review this at https://codereview.appspot.com/10005044/
>
> Affected files:
>   M src/cmd/cc/pgen.c


Is it already decided that we are switching to continuous stacks? The
thread on golang-dev does not have the final decision.

[khr1, 2013-06-10 19:49:03]

We haven't committed to it yet.  However, I'm planning on making a bunch of
compiler changes that I will need for it, as they will also be useful for
precise GC.  Basically, I need to do the same thing for cc as Carl did for
gc.


On Mon, Jun 10, 2013 at 12:41 PM, Dmitry Vyukov <dvyukov@google.com> wrote:

> On Mon, Jun 10, 2013 at 11:34 PM,  <khr@golang.org> wrote:
> > Reviewers: cshapiro,
> >
> > Message:
> > Hello cshapiro (cc: golang-dev@googlegroups.com),
> >
> > I'd like you to review this change to
> > https://khr%40golang.org@code.google.com/p/go/
> >
> >
> > Description:
> > cmd/cc: emit size of locals.  Will be used for stack copying.
> >
> > Please review this at https://codereview.appspot.com/10005044/
> >
> > Affected files:
> >   M src/cmd/cc/pgen.c
>
>
> Is it already decided that we are switching to continuous stacks? The
> thread on golang-dev does not have the final decision.
>

[rsc, 2013-06-10 20:17:04]

LGTM

[khr, 2013-06-11 16:01:30]

*** Submitted as https://code.google.com/p/go/source/detail?r=b43c4daaccba ***

cmd/cc: emit size of locals.  Will be used for stack copying.

R=cshapiro, dvyukov, khr, rsc
CC=golang-dev
https://codereview.appspot.com/10005044