state/apiserver: Split tests into multiple suites

state/apiserver: Split tests into multiple suites

Trivial change to split huge "suite" test suite
into multiple sub-suites, reusing common code
where possible.

https://code.launchpad.net/~dimitern/juju-core/054-apiserver-split-suites/+merge/167284

Requires: https://code.launchpad.net/~dimitern/juju-core/053-api-machiner-client-side/+merge/167278

(do not edit description out of merge proposal)

[dimitern, 2013-06-04 13:53:48]

Please take a look.

[mue, 2013-06-04 15:03:12]

Nice and clean reorganization, LGTM.

[rog, 2013-06-05 08:28:19]

LGTM with a couple of possible suggestions.

https://codereview.appspot.com/10003044/diff/1/state/apiserver/errors_test.go
File state/apiserver/errors_test.go (right):

https://codereview.appspot.com/10003044/diff/1/state/apiserver/errors_test.go...
state/apiserver/errors_test.go:16: baseSuite
i don't think there's any need to embed baseSuite here - it will just slow down
this suite. you could embed LoggingSuite instead if you like.

https://codereview.appspot.com/10003044/diff/1/state/apiserver/login_test.go
File state/apiserver/login_test.go (right):

https://codereview.appspot.com/10003044/diff/1/state/apiserver/login_test.go#...
state/apiserver/login_test.go:77: // connection. Seems wrong.
how else can we test Login independently of Open?

there's a comment about this particular test on the Info.Tag
field BTW.

https://codereview.appspot.com/10003044/diff/1/state/apiserver/scenario_test.go
File state/apiserver/scenario_test.go (right):

https://codereview.appspot.com/10003044/diff/1/state/apiserver/scenario_test....
state/apiserver/scenario_test.go:72: func (s *baseSuite) setUpScenario(c *C)
(entities []string) {
i'd be tempted to put this in api_test.go along with the other baseSuite
methods.

[dimitern, 2013-06-05 09:08:45]

Please take a look.

https://codereview.appspot.com/10003044/diff/1/state/apiserver/errors_test.go
File state/apiserver/errors_test.go (right):

https://codereview.appspot.com/10003044/diff/1/state/apiserver/errors_test.go...
state/apiserver/errors_test.go:16: baseSuite
On 2013/06/05 08:28:19, rog wrote:
> i don't think there's any need to embed baseSuite here - it will just slow
down
> this suite. you could embed LoggingSuite instead if you like.

Sure, good catch. Done.

https://codereview.appspot.com/10003044/diff/1/state/apiserver/login_test.go
File state/apiserver/login_test.go (right):

https://codereview.appspot.com/10003044/diff/1/state/apiserver/login_test.go#...
state/apiserver/login_test.go:77: // connection. Seems wrong.
On 2013/06/05 08:28:19, rog wrote:
> how else can we test Login independently of Open?
> 
> there's a comment about this particular test on the Info.Tag
> field BTW.

fwereade asked specifically for this comment btw.

https://codereview.appspot.com/10003044/diff/1/state/apiserver/scenario_test.go
File state/apiserver/scenario_test.go (right):

https://codereview.appspot.com/10003044/diff/1/state/apiserver/scenario_test....
state/apiserver/scenario_test.go:72: func (s *baseSuite) setUpScenario(c *C)
(entities []string) {
On 2013/06/05 08:28:19, rog wrote:
> i'd be tempted to put this in api_test.go along with the other baseSuite
> methods.

Done.

[dimitern, 2013-06-05 10:13:25]

*** Submitted:

state/apiserver: Split tests into multiple suites

Trivial change to split huge "suite" test suite
into multiple sub-suites, reusing common code
where possible.

R=mue, rog
CC=
https://codereview.appspot.com/10003044