Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(963)

Side by Side Diff: Makefile

Issue 9981044: Add a linter that checks for copyright headers.
Patch Set: Add a linter that checks for copyright headers. Created 11 years, 9 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | [revision details] » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Makefile debugging hack: uncomment the two lines below and make will tell you 1 # Makefile debugging hack: uncomment the two lines below and make will tell you
2 # more about what is happening. The output generated is of the form 2 # more about what is happening. The output generated is of the form
3 # "FILE:LINE [TARGET (DEPENDENCIES) (NEWER)]" where DEPENDENCIES are all the 3 # "FILE:LINE [TARGET (DEPENDENCIES) (NEWER)]" where DEPENDENCIES are all the
4 # things TARGET depends on and NEWER are all the files that are newer than 4 # things TARGET depends on and NEWER are all the files that are newer than
5 # TARGET. DEPENDENCIES will be colored green and NEWER will be blue. 5 # TARGET. DEPENDENCIES will be colored green and NEWER will be blue.
6 # 6 #
7 #OLD_SHELL := $(SHELL) 7 #OLD_SHELL := $(SHELL)
8 #SHELL = $(warning [$@ ($^) ($?) ])$(OLD_SHELL) 8 #SHELL = $(warning [$@ ($^) ($?) ])$(OLD_SHELL)
9 9
10 # Build a target for JavaScript files. The find command excludes directories 10 # Build a target for JavaScript files. The find command excludes directories
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 yuidoc-lint: $(JSFILES) 265 yuidoc-lint: $(JSFILES)
266 bin/lint-yuidoc 266 bin/lint-yuidoc
267 267
268 recess: node_modules/recess 268 recess: node_modules/recess
269 @# We need to grep for "Perfect" because recess does not set a 269 @# We need to grep for "Perfect" because recess does not set a
270 @# non-zero exit code if it rejects a file. If this fails, run the 270 @# non-zero exit code if it rejects a file. If this fails, run the
271 @# recess command below without the grep to get recess' report. 271 @# recess command below without the grep to get recess' report.
272 node_modules/recess/bin/recess lib/views/stylesheet.less \ 272 node_modules/recess/bin/recess lib/views/stylesheet.less \
273 --config recess.json | grep -q Perfect 273 --config recess.json | grep -q Perfect
274 274
275 lint: test-prep jshint gjslint recess yuidoc-lint test-filtering 275 lint: test-prep jshint gjslint recess lint-license-headers test-filtering \
276 » » yuidoc-lint
277
278 lint-license-headers:
279 » @# Take the list of JS files in one long line and break them into
280 » @# multiple lines (this assumes there are no spaces in the paths).
281 » @# Remove non-JS files, remove third-party files, and remove files in
282 » @# the root of the project. Finally, search for copyright notices in
283 » @# the files and report files that do not have one.
284 » echo $(JSFILES) | sed 's/ /\n/g' \
285 » | grep '\.js$$' | grep -v /assets/ | grep / \
286 » | xargs -I {} sh -c "grep -L '^Copyright (C) 2[^ ]* Canonical Ltd.' {}" \
287 » || (echo "The above files are missing copyright headers."; false)
276 288
277 virtualenv/bin/python: 289 virtualenv/bin/python:
278 virtualenv virtualenv 290 virtualenv virtualenv
279 291
280 virtualenv/bin/gjslint virtualenv/bin/fixjsstyle: virtualenv/bin/python 292 virtualenv/bin/gjslint virtualenv/bin/fixjsstyle: virtualenv/bin/python
281 virtualenv/bin/easy_install archives/closure_linter-latest.tar.gz 293 virtualenv/bin/easy_install archives/closure_linter-latest.tar.gz
282 294
283 beautify: virtualenv/bin/fixjsstyle 295 beautify: virtualenv/bin/fixjsstyle
284 virtualenv/bin/fixjsstyle --strict --nojsdoc --jslint_error=all $(JSFILE S) 296 virtualenv/bin/fixjsstyle --strict --nojsdoc --jslint_error=all $(JSFILE S)
285 297
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
585 endif 597 endif
586 598
587 # targets are alphabetically sorted, they like it that way :-) 599 # targets are alphabetically sorted, they like it that way :-)
588 .PHONY: beautify build build-files build-devel clean clean-all clean-deps \ 600 .PHONY: beautify build build-files build-devel clean clean-all clean-deps \
589 clean-docs code-doc debug devel docs dist gjslint help \ 601 clean-docs code-doc debug devel docs dist gjslint help \
590 install-npm-packages jshint lint main-doc npm-cache npm-cache-file \ 602 install-npm-packages jshint lint main-doc npm-cache npm-cache-file \
591 prep prod recess server spritegen test test-debug test-misc test-prep \ 603 prep prod recess server spritegen test test-debug test-misc test-prep \
592 test-prod undocumented view-code-doc view-docs view-main-doc yuidoc-lint 604 test-prod undocumented view-code-doc view-docs view-main-doc yuidoc-lint
593 605
594 .DEFAULT_GOAL := all 606 .DEFAULT_GOAL := all
OLDNEW
« no previous file with comments | « no previous file | [revision details] » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b