Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(55)

Issue 9974046: fix version-skew-cajoled tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by felix8a
Modified:
12 years, 9 months ago
Reviewers:
kpreid2
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

the version-skew-cajoled tests don't force es53, so they fail if the automode decides to use es5. In particular, Safari 6.0.4 passes the checks well enough that it defaults to es5 mode, so the version-skew-cajoled tests fail.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tests/com/google/caja/plugin/es53-test-cajajs-minor-version-skew-cajoled-module.js View 1 chunk +2 lines, -1 line 0 comments Download
M tests/com/google/caja/plugin/es53-test-cajajs-version-skew-cajoled-module.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
felix8a
12 years, 9 months ago (2013-06-03 22:17:35 UTC) #1
kpreid2
LGTM I think it would be a nice improvement to have a check that explicitly ...
12 years, 9 months ago (2013-06-04 17:02:46 UTC) #2
felix8a
12 years, 9 months ago (2013-06-04 19:29:12 UTC) #3
@r5438
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b