Issue 99640044: Actions() added to Charm interface

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 99640044: Actions() added to Charm interface

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by Bodie

Modified:
10 years, 10 months ago

Reviewers:
mp+221595

Visibility:
Public.

Description

Actions() added to Charm interface The Charm interface now specifies that Actions() must be implemented by any type that implements Charm. Actions() is a method which retrieves a map of ActionSpecs and other metadata on the charm's actions schema. This change also implements loading of Actions in charm/dir and charm/bundle, and adds actions.yaml to the dummy charm. https://code.launchpad.net/~binary132/juju-core/charm-interface-actions/+merge/221595 (do not edit description out of merge proposal)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -4 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charm/actions.go	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	charm/actions_test.go	View	1 2 3	2 chunks	+6 lines, -1 line	0 comments	Download
M	charm/bundle.go	View		3 chunks	+20 lines, -0 lines	0 comments	Download
M	charm/bundle_test.go	View		3 chunks	+14 lines, -0 lines	0 comments	Download
M	charm/charm.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	charm/charm_test.go	View	1 2 3	1 chunk	+15 lines, -0 lines	0 comments	Download
M	charm/dir.go	View		3 chunks	+19 lines, -0 lines	0 comments	Download
M	charm/dir_test.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	charm/meta_test.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	charm/repo_test.go	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	state/charm.go	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download
M	state/charm_test.go	View	1 2 3	2 chunks	+39 lines, -0 lines	0 comments	Download
M	state/conn_test.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	state/state.go	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	store/store.go	View		6 chunks	+10 lines, -0 lines	0 comments	Download
M	store/store_test.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	testing/repo/quantal/dummy/actions.yaml	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Issue 99640044: Actions() added to Charm interface

Description

Patch Set 1 #

Patch Set 2 : Actions() added to Charm interface #

Patch Set 3 : Actions() added to Charm interface #

Patch Set 4 : Actions() added to Charm interface #