Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2007)

Issue 99640044: Actions() added to Charm interface

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by Bodie
Modified:
9 years, 11 months ago
Reviewers:
mp+221595
Visibility:
Public.

Description

Actions() added to Charm interface The Charm interface now specifies that Actions() must be implemented by any type that implements Charm. Actions() is a method which retrieves a map of ActionSpecs and other metadata on the charm's actions schema. This change also implements loading of Actions in charm/dir and charm/bundle, and adds actions.yaml to the dummy charm. https://code.launchpad.net/~binary132/juju-core/charm-interface-actions/+merge/221595 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Actions() added to Charm interface #

Patch Set 3 : Actions() added to Charm interface #

Patch Set 4 : Actions() added to Charm interface #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -4 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M charm/actions.go View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M charm/actions_test.go View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M charm/bundle.go View 3 chunks +20 lines, -0 lines 0 comments Download
M charm/bundle_test.go View 3 chunks +14 lines, -0 lines 0 comments Download
M charm/charm.go View 1 chunk +1 line, -0 lines 0 comments Download
M charm/charm_test.go View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
M charm/dir.go View 3 chunks +19 lines, -0 lines 0 comments Download
M charm/dir_test.go View 1 1 chunk +10 lines, -0 lines 0 comments Download
M charm/meta_test.go View 1 chunk +4 lines, -0 lines 0 comments Download
M charm/repo_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M state/charm.go View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M state/charm_test.go View 1 2 3 2 chunks +39 lines, -0 lines 0 comments Download
M state/conn_test.go View 1 1 chunk +6 lines, -0 lines 0 comments Download
M state/state.go View 1 2 chunks +2 lines, -0 lines 0 comments Download
M store/store.go View 6 chunks +10 lines, -0 lines 0 comments Download
M store/store_test.go View 1 chunk +4 lines, -0 lines 0 comments Download
A testing/repo/quantal/dummy/actions.yaml View 1 chunk +8 lines, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b