Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(270)

Issue 99470044: cf-uaa relation to mysql

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by d.w.morriss
Modified:
11 years ago
Reviewers:
mp+220839, benjamin.saller, whit.morriss
Visibility:
Public.

Description

cf-uaa relation to mysql Add a relationship to mysql for HA. Some refactoring. https://code.launchpad.net/~whitmo/charms/trusty/cf-uaa/require-mysql/+merge/220839 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1682 lines, -106 lines) Patch
M .bzrignore View 1 chunk +1 line, -1 line 0 comments Download
M Makefile View 1 chunk +3 lines, -0 lines 0 comments Download
M README.md View 1 chunk +5 lines, -2 lines 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M hooks/charmhelpers/contrib/cloudfoundry/contexts.py View 1 chunk +14 lines, -0 lines 0 comments Download
M hooks/charmhelpers/core/templating.py View 3 chunks +5 lines, -2 lines 0 comments Download
A hooks/common.py View 1 chunk +30 lines, -0 lines 0 comments Download
D hooks/config.py View 1 chunk +0 lines, -29 lines 0 comments Download
M hooks/hooks.py View 2 chunks +52 lines, -40 lines 3 comments Download
M hooks/install View 2 chunks +22 lines, -28 lines 0 comments Download
A hooks/path.py View 1 chunk +1529 lines, -0 lines 0 comments Download
M metadata.yaml View 1 chunk +6 lines, -0 lines 0 comments Download
M templates/cf-registrar.conf View 1 chunk +3 lines, -3 lines 0 comments Download
M templates/cf-uaa.conf View 1 chunk +4 lines, -1 line 0 comments Download
M templates/uaa.yml View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3
d.w.morriss
Please take a look.
11 years ago (2014-05-23 18:11:41 UTC) #1
benjamin.saller
LGTM, thanks for this. just some trivial notes. I appreciate how we are getting by ...
11 years ago (2014-05-23 18:26:33 UTC) #2
whit.morriss
11 years ago (2014-05-23 19:10:45 UTC) #3
ack.

https://codereview.appspot.com/99470044/diff/1/hooks/hooks.py
File hooks/hooks.py (right):

https://codereview.appspot.com/99470044/diff/1/hooks/hooks.py#newcode12
hooks/hooks.py:12: from path import path
On 2014/05/23 18:26:32, benjamin.saller wrote:
> this could be added to the requirements rather than included directly, but I
> guess its ok

we could make a deb for path.py (or is there a way of defining pip installable
requirements that I have missed?).  I'd lobby we actually include it as part of
charm-helpers as it cleans up a wide variety of common fs operations and offers
a single point for mocking or patching for test purposes.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b