Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4212)

Issue 99410043: state/apiserver/common: StringResource

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by jameinel
Modified:
9 years, 11 months ago
Reviewers:
mp+220215, dimitern
Visibility:
Public.

Description

state/apiserver/common: StringResource This adds a new resource type: common.StringResource. It just lets us register "dataDir" as a Resource, instead of having to give Client secret insight into attributes of the srvRoot object. That brings us closer to having all of the Facades all part of a simple Registry instead of having special cases. https://code.launchpad.net/~jameinel/juju-core/api-named-resources-datadir/+merge/220215 Requires: https://code.launchpad.net/~jameinel/juju-core/api-named-resources/+merge/220208 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -6 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/apiserver/client/client.go View 2 chunks +1 line, -3 lines 0 comments Download
M state/apiserver/client/run.go View 4 chunks +11 lines, -2 lines 0 comments Download
M state/apiserver/common/resource.go View 1 chunk +12 lines, -0 lines 0 comments Download
M state/apiserver/common/resource_test.go View 1 chunk +9 lines, -0 lines 0 comments Download
M state/apiserver/root.go View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2
jameinel
Please take a look.
9 years, 11 months ago (2014-05-20 09:44:51 UTC) #1
dimitern
9 years, 11 months ago (2014-05-20 09:48:14 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b