Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(593)

Issue 992043: Inject gadgets.config into javascript servlet output for container output (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 9 months ago by Paul Lindner
Modified:
15 years, 8 months ago
Reviewers:
henry.saputra, shindig.remailer
Visibility:
Public.

Description

The Js servlet supports a container param without a way to inject container specific configs. Adding this code allows one to configure container side portion of the code. With some work this could also allow one to run gadgets.config code inside the js servlet output instead of the iframe.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsServlet.java View 5 chunks +29 lines, -3 lines 1 comment Download

Messages

Total messages: 2
Paul Lindner
any comments?
15 years, 9 months ago (2010-04-26 21:18:00 UTC) #1
henry.saputra
15 years, 9 months ago (2010-04-26 21:42:59 UTC) #2
Should we include the dependencies features to check for the container config?

http://codereview.appspot.com/992043/diff/1/2
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsServlet.java
(right):

http://codereview.appspot.com/992043/diff/1/2#newcode141
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsServlet.java:141:
for (String name : needed) {
Should we also get the config for the transitive dependency features?

If we do then we I think we need to call registry.getFeatures(needed) to get the
list of features requested that include the transitive dependencies feature
names.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b