Issue 991045: Add space to the allowed param name for OAuthRequest as decoded value

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 991045: Add space to the allowed param name for OAuthRequest as decoded value

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 10 months ago by henry.saputra

Modified:
15 years, 10 months ago

Reviewers:
chirag, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

The ALLOWED_PARAM_NAME used in OAuthRequest.allowParam to check against parameter name after being decoded from call to Oauth.decodeForm(). So if space is in the query parameter name is encoded correctly with "+" or "%20", eg: submit+job", the call to OAuth.sanitize(List<Parameter> params) will be decoded by OAuth.decodeForm method hence the param name to "submit job" which will cause it to fail pattern match. This query parameter name (with space) is legal since it will be later be encoded when signing the OAuthRequest inside OAuthSignature.getBaseString. Adding space as allowed character in the OAuthRequest.ALLOWED_PARAM_NAME.

Patch Set 1 #

Created: 15 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lgtm

Expand All Messages | Collapse All Messages