Issue 1197: Caja should apply autocomplete="off" on forms by default

erikeldridge said:
  I'd like to be able to do something like this:
  <input autocomplete="false"/>

  But the cajoler removes it w/ this warning:
  WARNING http:///:1+8 - 20: removing unknown attribute autocomplete
  on input:http:///:1: <input autocomplete="false"/>

Define autocomplete attribute for form and input and only allow the
off attribute.


Submitted @4061

[Jasvir, 2010-04-27 22:21:37]

LGTM

http://codereview.appspot.com/991042/diff/1/3
File src/com/google/caja/lang/html/html4-attributes-extensions-defs.json
(right):

http://codereview.appspot.com/991042/diff/1/3#newcode21
src/com/google/caja/lang/html/html4-attributes-extensions-defs.json:21: ]
Spurious quotes?

[MikeSamuel, 2010-04-27 22:58:46]

http://codereview.appspot.com/991042/diff/1/3
File src/com/google/caja/lang/html/html4-attributes-extensions-defs.json
(right):

http://codereview.appspot.com/991042/diff/1/3#newcode21
src/com/google/caja/lang/html/html4-attributes-extensions-defs.json:21: ]
On 2010/04/27 22:21:37, jasvir wrote:
> Spurious quotes?

just the way Rietveld shows tabs.  fixed

[DavidSarah, 2010-04-28 00:01:22]

http://codereview.appspot.com/991042/diff/1/3
File src/com/google/caja/lang/html/html4-attributes-extensions-defs.json
(right):

http://codereview.appspot.com/991042/diff/1/3#newcode16
src/com/google/caja/lang/html/html4-attributes-extensions-defs.json:16: { "key":
"FORM::AUTOCOMPLETE", "description": "",
Shouldn't there be a non-empty description?

http://codereview.appspot.com/991042/diff/1/2
File tests/com/google/caja/plugin/templates/TemplateCompilerTest.java (right):

http://codereview.appspot.com/991042/diff/1/2#newcode230
tests/com/google/caja/plugin/templates/TemplateCompilerTest.java:230: + "       
});"
Why has this changed in this CL?

http://codereview.appspot.com/991042/diff/1/2#newcode856
tests/com/google/caja/plugin/templates/TemplateCompilerTest.java:856: }
There doesn't appear to be a test in which the input includes
'autocomplete="off"'.

[MikeSamuel, 2010-04-28 00:42:33]

http://codereview.appspot.com/991042/diff/1/2
File tests/com/google/caja/plugin/templates/TemplateCompilerTest.java (right):

http://codereview.appspot.com/991042/diff/1/2#newcode230
tests/com/google/caja/plugin/templates/TemplateCompilerTest.java:230: + "       
});"
On 2010/04/28 00:01:22, DavidSarah wrote:
> Why has this changed in this CL?

Because it was over 80 columns.

http://codereview.appspot.com/991042/diff/1/2#newcode856
tests/com/google/caja/plugin/templates/TemplateCompilerTest.java:856: }
On 2010/04/28 00:01:22, DavidSarah wrote:
> There doesn't appear to be a test in which the input includes
> 'autocomplete="off"'.

Will do