Issue 99080044: Specify socket timeout for Web service calls

Issue 99080044: Specify socket timeout for Web service calls (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by Tanmay Vartak

Modified:
10 years, 7 months ago

Reviewers:
pjo

CC:
connector-cr_google.com

Visibility:
Public.

More Reviews

Description

Specify socket timeout for Web service calls

Patch Set 2 : With unit tests #

Total comments: 1

Patch Set 3 : with code review comment implemented #

Total comments: 3

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+238 lines, -30 lines)			Patch
M	src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java	View	1 2	5 chunks	+25 lines, -7 lines	2 comments	Download
M	src/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptor.java	View	1 2	5 chunks	+26 lines, -8 lines	1 comment	Download
M	test/com/google/enterprise/adaptor/sharepoint/DelegatingSiteData.java	View	1	2 chunks	+30 lines, -1 line	0 comments	Download
M	test/com/google/enterprise/adaptor/sharepoint/SharePointAdaptorTest.java	View	1	13 chunks	+124 lines, -13 lines	0 comments	Download
M	test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java	View		3 chunks	+33 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

pjo

Thank you https://codereview.appspot.com/99080044/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java (right): https://codereview.appspot.com/99080044/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java#newcode269 src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:269: private int socketTimeout; add units to var ...

10 years, 7 months ago (2014-05-13 00:00:55 UTC) #2

pjo

Thank you https://codereview.appspot.com/99080044/diff/20001/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java (right): https://codereview.appspot.com/99080044/diff/20001/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java#newcode269 src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:269: private int socketTimeout; still doesn't have units ...

10 years, 7 months ago (2014-05-13 18:09:08 UTC) #4

pjo

10 years, 7 months ago (2014-05-13 18:26:07 UTC) #6

LGTM.  Thank you

https://codereview.appspot.com/99080044/diff/40001/src/com/google/enterprise/...
File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java
(right):

https://codereview.appspot.com/99080044/diff/40001/src/com/google/enterprise/...
src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:269: private
int socketTimeoutInMilliSeconds;
s/MillisSeconds/Millis/

https://codereview.appspot.com/99080044/diff/40001/src/com/google/enterprise/...
src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:494:
config.getValue("adaptor.docHeaderTimeoutSecs")) * 1000;
this value makes sense for connect but not for entire request.


IMO adaptor.docContentTimeoutSecs makes sense for request

https://codereview.appspot.com/99080044/diff/40001/src/com/google/enterprise/...
File
src/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptor.java
(right):

https://codereview.appspot.com/99080044/diff/40001/src/com/google/enterprise/...
src/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptor.java:852:
}
same comments as SPA

Expand All Messages | Collapse All Messages